[OAK-5199] Test coverage for ExternalGroupRef

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 1.5.16, 1.6.0
• Component/s: auth-external
• Assignee: Manfred Baedke
• Reporter: Angela Schreiber
• Created: 30/Nov/16 17:19
• Updated: 23/Dec/16 04:37
• Resolved: 15/Dec/16 17:25

Description

baedke, in addition to the missing documentation, i just noticed that there is also no tests for the new ExternalGroupRef you added recently.

IMHO its crucial that we don't introduce new features/improvements/fixes without tests... this has been one of the big issues in the past and I really want the old bad habits that of the oak-auth-external module to be continue. The lack of test and documentation coverage has just been so troublesome in the past.

If that is not possible by mutual agreement among all devs working on this module, I would suggest that we introduce automatic control into the pom.xml that fails the build if the test-coverage drops with a given change.

Issue Links

• is related to: OAK-5200 OAK-4930 introduced critical bug confusing id and principal name
• is related to: OAK-4930 External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()