[OAK-4930] External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.20, 1.4.8, 1.5.12
• Fix Version/s: 1.4.9, 1.5.13, 1.6.0
• Component/s: auth-external
• Assignee: Manfred Baedke
• Reporter: Manfred Baedke
• Created: 12/Oct/16 16:53
• Updated: 20/Jun/18 13:18
• Resolved: 13/Oct/16 14:47

Description

When recursively collecting principal names associated with the declared group memberships of a given principal, the method DynamicSyncContext.collectPrincipalNames() unnecessarily calls IdentityProvider.getIdentity() for every declared group reference, though it is only necessary when the actual depth of the remaining recursion is >1.

Issue Links

• breaks: OAK-5200 OAK-4930 introduced critical bug confusing id and principal name
• is depended upon by: OAK-4931 LdapIdentityProvider doesn't use configured custom attributes for all searches
• is related to: OAK-5209 Save roundtrips to external identity servers
• is superceded by: OAK-5210 Ability to resolve principal name from ExternalIdentityRef without IDP roundtrip
• relates to: OAK-5198 Javadoc and Documentation of ExternalGroupRef
• relates to: OAK-5199 Test coverage for ExternalGroupRef