Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: core, jcr
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Jukka Zitting added a comment -

        Like in OAK-64 for the privilege registry, in revision 1368083 I adjusted the SessionImpl class to return dummy instances of the PrincipalManagerImpl and UserManagerImpl classes when executing with -Dtodo=log or -Dtodo=none. The default behavior remains to throw an UnsupportedRepositoryOperationException.

        Show
        Jukka Zitting added a comment - Like in OAK-64 for the privilege registry, in revision 1368083 I adjusted the SessionImpl class to return dummy instances of the PrincipalManagerImpl and UserManagerImpl classes when executing with -Dtodo=log or -Dtodo=none . The default behavior remains to throw an UnsupportedRepositoryOperationException .
        Hide
        Chetan Mehrotra added a comment - - edited

        Couple of minor issues in user management area

        • A null check for intermediatePath in o.a.j.oak.jcr.security.user.UserManagerImpl#createUser is required
        • o.a.j.oak.security.user.UserProviderImpl#getAuthorizableByPrincipal -
          -                Iterator rows = result.getRows().iterator();
          +                Iterator<? extends ResultRow> rows = result.getRows().iterator();
                           if (rows.hasNext()) {
          -                    String path = rows.next().toString();
          +                    String path = rows.next().getPath();
                               authorizableTree = root.getTree(path);
                           }
          
        Show
        Chetan Mehrotra added a comment - - edited Couple of minor issues in user management area A null check for intermediatePath in o.a.j.oak.jcr.security.user.UserManagerImpl#createUser is required o.a.j.oak.security.user.UserProviderImpl#getAuthorizableByPrincipal - - Iterator rows = result.getRows().iterator(); + Iterator<? extends ResultRow> rows = result.getRows().iterator(); if (rows.hasNext()) { - String path = rows.next().toString(); + String path = rows.next().getPath(); authorizableTree = root.getTree(path); }
        Hide
        Jukka Zitting added a comment -

        See revision 1378974 for a fairly large change where I moved the per-session validators from within RootImpl up to the ContentRepository level. Instead of instantiating new validators for each session or explicitly passing the AccessControlContext to the commit hooks, I'm using the JAAS Subject.doAs() mechanism to pass the required information to the access control validators.

        Show
        Jukka Zitting added a comment - See revision 1378974 for a fairly large change where I moved the per-session validators from within RootImpl up to the ContentRepository level. Instead of instantiating new validators for each session or explicitly passing the AccessControlContext to the commit hooks, I'm using the JAAS Subject.doAs() mechanism to pass the required information to the access control validators.
        Hide
        Jukka Zitting added a comment -

        Couple of minor issues in user management area

        Thanks! Committed in revision 1378984.

        Show
        Jukka Zitting added a comment - Couple of minor issues in user management area Thanks! Committed in revision 1378984.
        Hide
        Alex Parvulescu added a comment -

        Linking to the proper issue that tracks the node type problem (OAK-325)

        Show
        Alex Parvulescu added a comment - Linking to the proper issue that tracks the node type problem ( OAK-325 )
        Hide
        angela added a comment -

        it doesn't make sense to set the fix version of the container to something lower that the one of any subtask!

        Show
        angela added a comment - it doesn't make sense to set the fix version of the container to something lower that the one of any subtask!
        Hide
        Alex Parvulescu added a comment -

        bulk close for the 0.15 release

        Show
        Alex Parvulescu added a comment - bulk close for the 0.15 release

          People

          • Assignee:
            angela
            Reporter:
            angela
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development