Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1266 DocumentStore implementation for relational databases
  3. OAK-4477

RDBDatasourceFactory should use pool config similar to sling datasource defaults

    XMLWordPrintableJSON

    Details

    • Type: Technical task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.31, 1.2.16, 1.4.3, 1.5.3
    • Fix Version/s: 1.0.33, 1.2.18, 1.4.6, 1.5.6, 1.6.0
    • Component/s: rdbmk
    • Labels:
      None

      Description

      RDBDataSourceFactory is used only for testing, and creates instances of org.apache.tomcat.jdbc.pool.DataSource.

      These are currently created with default config, while org.apache.sling.datasource (which is likely used in production) uses it's own defaults. In particular, it configures three interceptors – StatementCache;SlowQueryReport(threshold=10000);ConnectionState – which we do not, thus they aren't getting unit test coverage.

        Attachments

        1. OAK-4477.diff
          1.0 kB
          Julian Reschke

          Issue Links

            Activity

              People

              • Assignee:
                reschke Julian Reschke
                Reporter:
                reschke Julian Reschke
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: