[OAK-4477] RDBDatasourceFactory should use pool config similar to sling datasource defaults

• Type: Technical task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.31, 1.2.16, 1.4.3, 1.5.3
• Fix Version/s: 1.0.33, 1.2.18, 1.4.6, 1.5.6, 1.6.0
• Component/s: rdbmk
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 16/Jun/16 11:36
• Updated: 10/Nov/16 08:51
• Resolved: 14/Jul/16 15:41

Description

RDBDataSourceFactory is used only for testing, and creates instances of org.apache.tomcat.jdbc.pool.DataSource.

These are currently created with default config, while org.apache.sling.datasource (which is likely used in production) uses it's own defaults. In particular, it configures three interceptors – StatementCache;SlowQueryReport(threshold=10000);ConnectionState – which we do not, thus they aren't getting unit test coverage.

Issue Links

• is related to: OAK-4557 RDBPreparedStatementWrapper: do not hide implementation bugs
• is related to: OAK-4559 RDB*Store: failures with Tomcat JDBC pool's StatementCache interceptor
• is related to: OAK-4482 RDB*Store: update tomcat-jdbc test dependency