[OAK-4066] Suggestion dictionary don't update after suggestUpdateFrequencyMinutes unless something else causes index update

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.3.16
• Fix Version/s: 1.4, 1.4.0
• Component/s: lucene
• Assignee: Vikas Saurabh
• Reporter: Vikas Saurabh
• Created: 25/Feb/16 18:24
• Updated: 01/Aug/16 05:44
• Resolved: 29/Feb/16 18:20

Description

Currently, suggestions building is tied at the end of indexing cycle. Along with that we check if diff between currTime and lastSugguestionBuildTime is more than suggestUpdateFrequencyMinutes before deciding to build suggestions or not.

This allows for suggestions not getting updated if:

• At T1 suggestions are built
• At T2 an index update takes place but suggestions aren't rebuilt because not enough time has passed since T1
• Now at T3 (after sufficient time), changes at T2 won't show up for suggestions until some other index change happens.

We should probably see track about last changes in index (at T2) and use that too while running indexing cycle at T3.

Issue Links

• is related to: OAK-4075 Suggestion index update requires at least one non-hidden commit to get kick-started