[OAK-4009] Search done via Lucene index might return duplicate results

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.2.14, 1.3.16, 1.4
• Component/s: lucene
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 12/Feb/16 06:09
• Updated: 07/Apr/16 04:18
• Resolved: 12/Feb/16 08:41

Description

In certain cases (like one explained in OAK-2569) it can happen that Lucene index version gets updated in between a cursor traversal. Then the offset used would be wrong and currently the LucenePropertyIndex would run the query without offset which can result in duplicate rows.

As that time we relied on seenPaths for ensuring that duplicate paths would be detected. However a closer look at code flow now indicates that it gets used only for those queries where we do path transformation [1] and not in all cases.

Also earlier we did used unique cursor but we changed that in OAK-2754 in favour of seenPaths. So as a fix we should revert that back and use unique cursor there

[1] search on jcr:conent/@title and actual search done for 'title' and path checked to end with jcr:content

Issue Links

• is broken by: OAK-2754 Use non unique PathCursor in LucenePropertyIndex
• is related to: OAK-2569 LuceneIndex#loadDocs can throw IllegalArgumentException
• is related to: OAK-4167 Collect and backport lucene based suggestion improvements done in 1.4 into 1.2 branch