[OAK-3917] SuggestionHelper creating unnecessary temporary directories

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.20, 1.3.15, 1.4
• Component/s: lucene
• Assignee: Vikas Saurabh
• Reporter: Chetan Mehrotra
• Created: 25/Jan/16 05:56
• Updated: 05/Oct/16 08:52
• Resolved: 27/Jan/16 18:31

Description

SuggestHelper create a temporary directory [1] mostly likely as a workaround to allow use of OakDirectory. With time this can grow unbounded (as dir is not cleaned) and following exception is seen.

java.lang.IllegalStateException: Failed to create directory within 10000 attempts (tried 1453697999939-0 to 1453697999939-9999)
        at com.google.common.io.Files.createTempDir(Files.java:608)
        at org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:107)
        at org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.<init>(IndexNode.java:106)
        at org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.open(IndexNode.java:69)
        at org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.findIndexNode(IndexTracker.java:162)
        at org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.acquireIndexNode(IndexTracker.java:137)
        at org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex.getPlans(LucenePropertyIndex.java:222)

[1] https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.3.14/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/SuggestHelper.java#L107

Issue Links

• is related to: OAK-4167 Collect and backport lucene based suggestion improvements done in 1.4 into 1.2 branch