[OAK-3156] Lucene suggestions index definition can't be restricted to a specific type of node

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.2.14, 1.3.9, 1.4
• Component/s: lucene
• Assignee: Tommaso Teofili
• Reporter: Vikas Saurabh
• Created: 29/Jul/15 08:21
• Updated: 08/Oct/19 15:22
• Resolved: 13/Oct/15 11:15

Description

While performing a suggestor query like

SELECT [rep:suggest()] as suggestion  FROM [nt:unstructured] WHERE suggest('foo')

Suggestor does not provide any result. In current implementation, suggestions in Oak work only for index definitions for nt:base nodetype.
So, an index definition like:

    <lucene-suggest
        jcr:primaryType="oak:QueryIndexDefinition"
        async="async"
        compatVersion="{Long}2"
        type="lucene">
        <indexRules jcr:primaryType="nt:unstructured">
            <nt:base jcr:primaryType="nt:unstructured">
                <properties jcr:primaryType="nt:unstructured">
                    <description
                        jcr:primaryType="nt:unstructured"
                        analyzed="{Boolean}true"
                        name="description"
                        propertyIndex="{Boolean}true"
                        useInSuggest="{Boolean}true"/>
                </properties>
            </nt:base>
        </indexRules>
    </lucene-suggest>

works, but if we change nodetype to nt:unstructured like:

    <lucene-suggest
        jcr:primaryType="oak:QueryIndexDefinition"
        async="async"
        compatVersion="{Long}2"
        type="lucene">
        <indexRules jcr:primaryType="nt:unstructured">
            <nt:unstructured jcr:primaryType="nt:unstructured">
                <properties jcr:primaryType="nt:unstructured">
                    <description
                        jcr:primaryType="nt:unstructured"
                        analyzed="{Boolean}true"
                        name="description"
                        propertyIndex="{Boolean}true"
                        useInSuggest="{Boolean}true"/>
                </properties>
            </nt:base>
        </indexRules>
    </lucene-suggest>

, it won't work.

The issue is that suggestor implementation essentially is passing a pseudo row with path=/.:

LucenePropertyIndex.java

    private boolean loadDocs() {
...
                        queue.add(new LuceneResultRow(suggestedWords));
...

and

LucenePropertyIndex.java

        LuceneResultRow(Iterable<String> suggestWords) {
            this.path = "/";
            this.score = 1.0d;
            this.suggestWords = suggestWords;
        }

Due to path being set to "/", SelectorImpl later filters out the result as rep:root (primary type of "/") isn't a nt:unstructured.

Issue Links

• is related to: OAK-3509 Lucene suggestion results should have 1 row per suggestion with appropriate column names
• is related to: OAK-4167 Collect and backport lucene based suggestion improvements done in 1.4 into 1.2 branch
• relates to: OAK-3507 Virtual index rows should have paths as 'null'

Sub-Tasks

• Query engine should support virtual index rows: Closed