[OAK-1958] Session.logout performance poor

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.1
• Fix Version/s: 1.0.2, 1.1.0
• Component/s: jcr
• Labels: Performance

Environment

linux jdk1.7 b25 and b55.

• Assignee: Michael Dürig
• Reporter: Rob Ryan
• Created: 08/Jul/14 20:50
• Updated: 29/Sep/22 07:42
• Resolved: 09/Jul/14 10:36

Description

Problem:
Session.logout was observed to take 14% of time in a performance test of a reasonably real-world load.

Method:
Use the attached sling junit test case to run 8 concurrent instances of the test. profile with YourKit or similar and see >50% time taken by logout.

Expected:
Logout should be practically free.

Solution:
The attached patch avoids a bug in guava-15 (still present in guava-17 the latest) where the former use of addCallback triggered many CancellationExceptions when sessions were quickly created and logged out.

Issue Links

• is related to: OAK-9959 RepositoryImpl.shutdown() takes way too long in case of unclosed Sessions