[OAK-9959] RepositoryImpl.shutdown() takes way too long in case of unclosed Sessions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.44.0
• Fix Version/s: 1.46.0
• Component/s: jcr
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 29/Sep/22 06:37
• Updated: 21/Dec/22 03:39
• Resolved: 11/Oct/22 06:26

Description

For ITs I have to spin up new in-memory repositories for individual tests and shut them down afterwards. While the startup time is really good, I loose almost 5 seconds while calling RepositoryImpl.shutdown() (https://github.com/apache/jackrabbit-oak/blob/cde907088a5c460178fd714cb4edc141cd45e23d/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/repository/RepositoryImpl.java#L348) during closing the scheduledExecutor.

This only happens though when there are unclosed sessions due to this executor which is scheduled to run after 1 minute: https://github.com/apache/jackrabbit-oak/blob/cde907088a5c460178fd714cb4edc141cd45e23d/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/repository/RepositoryImpl.java#L324.

Would be good though to speed up shutdown even in the case of unclosed sessions.

Issue Links

• relates to: OAK-941 MBean to track sessions
• relates to: OAK-1958 Session.logout performance poor
• links to: GitHub PR
• links to: GitHub Pull Request #724