[OAK-10272] Reverse #OAK-10022

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.48.0
• Fix Version/s: 1.56.0
• Component/s: segment-azure
• Assignee: Miroslav Smiljanic
• Reporter: Carlo Jelmini
• Created: 07/Jun/23 09:01
• Updated: 20/Sep/23 16:04
• Resolved: 16/Aug/23 11:16

Description

The changes introduced in OAK-10022, where the binary references  file (.brf) is updated on every flush should be reverted.

They were introduced to fix a NullPointerException
thrown in ReadOnlyFileStore#collectBlobReferences because of the absence of the .brf file in the last open archive. However this fix was not enough and a new fix was needed (OAK-10212).
This means the changes in OAK-10022 are no longer necessary. Given that updating the brf file in-place frequently on Azure can impact write performance and backup tooling, it's better to roll them back.

Issue Links

• fixes: OAK-10343 AzureTarFilesTest.testCollectBlobReferencesWithGenerationFilter unreliable
• fixes: OAK-10359 Unreliable test: TarFileTest.binaryReferencesIndexShouldBeTrimmedDownOnSweep
• fixes: OAK-10360 unreliable test AzureTarFileTest.testWriteAndReadBinaryReferences
• fixes: OAK-10293 AzureTarRevisionsTest fails occasionally
• is related to: OAK-10022 ReadOnlyFileStore#collectBlobReferences throws NullPointerException if azure blob with binary references is missing in the tar directory
• links to: GitHub Pull Request #1070