Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-10272

Reverse #OAK-10022

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.48.0
    • 1.56.0
    • segment-azure
    • None

    Description

      The changes introduced in OAK-10022, where the binary references  file (.brf) is updated on every flush should be reverted.

      They were introduced to fix a NullPointerException
      thrown in ReadOnlyFileStore#collectBlobReferences because of the absence of the .brf file in the last open archive. However this fix was not enough and a new fix was needed (OAK-10212).
      This means the changes in OAK-10022 are no longer necessary. Given that updating the brf file in-place frequently on Azure can impact write performance and backup tooling, it's better to roll them back.

      Attachments

        Issue Links

        fixes

        Bug - A problem which impairs or prevents the functions of the product. OAK-10343 AzureTarFilesTest.testCollectBlobReferencesWithGenerationFilter unreliable

        • Major - Major loss of function.
        • Closed

        Bug - A problem which impairs or prevents the functions of the product. OAK-10359 Unreliable test: TarFileTest.binaryReferencesIndexShouldBeTrimmedDownOnSweep

        • Major - Major loss of function.
        • Closed

        Bug - A problem which impairs or prevents the functions of the product. OAK-10360 unreliable test AzureTarFileTest.testWriteAndReadBinaryReferences

        • Major - Major loss of function.
        • Closed

        Bug - A problem which impairs or prevents the functions of the product. OAK-10293 AzureTarRevisionsTest fails occasionally

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed
        is related to

        Bug - A problem which impairs or prevents the functions of the product. OAK-10022 ReadOnlyFileStore#collectBlobReferences throws NullPointerException if azure blob with binary references is missing in the tar directory

        • Major - Major loss of function.
        • Closed
        links to

        Web Link GitHub Pull Request #1070

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            miroslav Miroslav Smiljanic
            jelmini Carlo Jelmini
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment