Uploaded image for project: 'Nutch'
  1. Nutch
  2. NUTCH-2815 Add Spotbugs target to build and address detected "bugs"
  3. NUTCH-2817

Avoid check for equality of URL path and file part using ==/!=

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.17
    • Fix Version/s: 1.18
    • Component/s: plugin, protocol
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      In the plugins protocol-file and protocol-ftp Spotbugs warns about "Comparison of String objects using == or !=". This is actual a false positive since path and file point to the same object for URLs with no query part (a query is not supported for file:// and ftp://). To check for existence of the query part would be better to understand and also avoids the Spotbugs warning.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              snagel Sebastian Nagel

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment