Uploaded image for project: 'Nutch'
  1. Nutch
  2. NUTCH-2815 Add Spotbugs target to build and address detected "bugs"
  3. NUTCH-2817

Avoid check for equality of URL path and file part using ==/!=

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.17
    • 1.18
    • plugin, protocol
    • None
    • Patch Available

    Description

      In the plugins protocol-file and protocol-ftp Spotbugs warns about "Comparison of String objects using == or !=". This is actual a false positive since path and file point to the same object for URLs with no query part (a query is not supported for file:// and ftp://). To check for existence of the query part would be better to understand and also avoids the Spotbugs warning.

      Attachments

        Issue Links

          links to

          Web Link GitHub Pull Request #548

          Activity

            People

              Unassigned Unassigned
              snagel Sebastian Nagel
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: