[NUTCH-2815] Add Spotbugs target to build and address detected "bugs"

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17
• Fix Version/s: 1.21
• Component/s: build
• Labels: help-wanted
• Assignee: Unassigned
• Reporter: Sebastian Nagel
• Created: 08/Aug/20 08:16
• Updated: 30/Mar/24 17:19

Description

(thanks to lewismc for the suggestion and the patch to run Spotbugs)

• add Spotbugs static code analysis to the Nutch build scripts (called on-demand as ant target "spotbugs)

• fix detected "bugs" (at least, those classified as high priority). Sub-tasks to be opened to address groups of similar "bugs".

Issue Links

• is related to: NUTCH-1807 avoid methods relying on system-specific default locale / charset

Sub-Tasks

• Add Spotbugs target to ant build: Closed
• Avoid check for equality of URL path and file part using ==/!=: Closed
• Move spotbugs "installation" directory to avoid that spotbugs is shipped in Nutch runtime: Closed
• Methods returning array may expose internal representation: Open
• Fix various bugs spotted by NUTCH-2815: Closed
• Method ignores exceptional return value: Closed
• Random object created and used only once: Closed
• Method invokes System.exit(...) 9 bugs: Closed
• Fix impossible casts: Closed