[NIFI-2491] ControllerService startup issue

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.7.1
• Assignee: Unassigned
• Reporter: Brandon Rhys DeVries
• Created: 05/Aug/16 13:31
• Updated: 07/Mar/17 18:18
• Resolved: 07/Mar/17 18:18

Description

In the process of testing NIFI-2160 and NIFI-2344, we found that if a controller service throws some type of RuntimeException(e.g. IllegalStateException) in its @OnEnabled method it will essentially "break the chain" of startup of things that depend on it. The end result is that in a cluster, you can have a processor that is running on some nodes and stopped on others. This probably isn't the desired behavior. In StandardControllerServiceProvider[1] when thrown Exceptions are caught, we should possibly retry enabling the service. If it can't be enabled... we might want to consider shutting down NiFi. That's sort of extreme, but allowing the cluster to enter an inconsistent state seems like a bad thing. We could possibly also come up with some way of indicating there's an inconsistency in the UI. The proper solution will require some consideration, but the issue needs to be addressed somehow.

[1] https://github.com/apache/nifi/blob/rel/nifi-0.7.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java#L320-L325

Issue Links

• is related to: NIFI-2492 Processor startup issue