[NIFI-2344] non-required Controller services disabled on restart

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 1.0.0, 0.7.1, 1.0.0-Beta
• Assignee: Oleg Zhurakousky
• Reporter: Brandon Rhys DeVries
• Created: 21/Jul/16 14:10
• Updated: 07/Oct/16 19:26
• Resolved: 26/Jul/16 04:49

Description

So... the problem from NIFI-2160 isn't quite dead yet. The fix for that ticket recursively enumerates controller services that a controller service references, but only if they are required[1]. However, there are many cases in which referenced controller services may not be required properties:

DistributedMapCacheClientService - SSL Context Service
DistributedMapCacheServer - SSL Context Service
DistributedSetCacheClientService - SSL Context Service
DistributedSetCacheServer - SSL Context Service
JMSConnectionFactoryProvider - SSL Context Service

This causes the above services to become disabled on restart if they were previously enabled. I'd propose changing the line:

if (descriptor.getControllerServiceDefinition() != null && descriptor.isRequired()) {

to:

if (descriptor.getControllerServiceDefinition() != null && pEntry.getValue() != null) {

[1] https://github.com/apache/nifi/blob/rel/nifi-0.7.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java#L121

Issue Links

• links to: GitHub Pull Request #711