[NET-89] [net] TelnetClient broken for binary transmissions + solution

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: Telnet

Environment

Operating System: All
Platform: All

• Bugzilla Id: 34763
• Assignee: Unassigned
• Reporter: Colin Surprenant
• Created: 06/May/05 00:17
• Updated: 04/Jun/11 19:26
• Resolved: 22/Mar/11 17:16

Description

TelnetClient does not handle correctly binary transmissions in two places:

First in TelnetClient#connectAction() the telnet input and output streams are
wrapped in the NetASCII streams to handle net vs platform line separator
conversion which breaks the binary data. My quick solution was to simply remove
those two wrapping streams. A more general solution might be to provide access
to the unfilterer stream with methods like getUnfilteredInputStream and
getUnfilteredOutputStream or to dynamically stop the NetASCII stream from
'corrupting' the stream when a TelnetOption.BINARY option is negotiated.

Also, in TelnetInputStream#__read() there is a bug in the __receiveState
handling for the _STATE_IAC state. When a second consecutive IAC (0x255) is
received to encode the single 0x255 character, read does not return 0x255 but
instead move on to reading the next char in the stream.
...

The above bug report has been moved to the subtask NET-329

I'll provide patches for this.
Colin.

Issue Links

• is duplicated by: NET-387 TelnetClient use of FromNetASCIIInputStream and ToNetASCIIOutputStream breaks binary mode on non-Windows platforms
• relates to: NET-173 Duplicate IAC when sending a IAC using TelnetClient.getOutputStream()

Sub-Tasks

• TelnetInoutStream#__read() bug in the __receiveState handling for the _STATE_IAC state.: Closed