[NET-329] TelnetInoutStream#__read() bug in the __receiveState handling for the _STATE_IAC state.

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.2
• Assignee: Unassigned
• Reporter: Sebb
• Created: 10/Jul/10 23:59
• Updated: 04/Jun/11 19:25
• Resolved: 11/Jul/10 00:23

Description

Moved from NET-89:

Also, in TelnetInputStream#__read() there is a bug in the __receiveState
handling for the _STATE_IAC state. When a second consecutive IAC (0x255) is
received to encode the single 0x255 character, read does not return 0x255 but
instead move on to reading the next char in the stream.

The current code reads:

case _STATE_IAC:
    switch (ch)
    {
    case TelnetCommand.WILL:
        __receiveState = _STATE_WILL;
        continue;
    case TelnetCommand.WONT:
        __receiveState = _STATE_WONT;
        continue;
    case TelnetCommand.DO:
        __receiveState = _STATE_DO;
        continue;
    case TelnetCommand.DONT:
        __receiveState = _STATE_DONT;
        continue;
    /* TERMINAL-TYPE option (start)*/
    case TelnetCommand.SB:
        __suboption_count = 0;
        __receiveState = _STATE_SB;
        continue;
    /* TERMINAL-TYPE option (end)*/
    case TelnetCommand.IAC:
        __receiveState = _STATE_DATA;
        break;
    default:
        break;
    }
    __receiveState = _STATE_DATA;
    continue;
case _STATE_WILL:

but it should be:

case _STATE_IAC:
    switch (ch)
    {
    case TelnetCommand.WILL:
        __receiveState = _STATE_WILL;
        continue;
    case TelnetCommand.WONT:
        __receiveState = _STATE_WONT;
        continue;
    case TelnetCommand.DO:
        __receiveState = _STATE_DO;
        continue;
    case TelnetCommand.DONT:
        __receiveState = _STATE_DONT;
        continue;
    /* TERMINAL-TYPE option (start)*/
    case TelnetCommand.SB:
        __suboption_count = 0;
        __receiveState = _STATE_SB;
        continue;
    /* TERMINAL-TYPE option (end)*/
    case TelnetCommand.IAC:
        __receiveState = _STATE_DATA;
        break; // exit to enclosing switch to return from read
    default:
        __receiveState = _STATE_DATA;           
        continue; // move on the next char
    }
    break; // exit and return from read
case _STATE_WILL: