MyFaces Core
  1. MyFaces Core
  2. MYFACES-1681

UIComponent.getAttributes() too restrictive

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.5, 1.2.0
    • Fix Version/s: 1.2.2
    • Component/s: JSR-252
    • Labels:
      None
    • Environment:
      SE 1.6.0_02
      GlassFish V2 admingui

      Description

      The Map returned by UIComponent.getAttributes() is too restrictive with respect
      to null values.

      MyFaces will always throw an NPE for a null value. Granted, the following is
      in the javadocs:

      • Any attempt to add a null key or value must throw a NullPointerException.

      However, the following is also in the same section:

      • put() - If the property is writeable, call the setter method to set the corresponding value (unwrapping primitive values in their
        corresponding wrapper classes). If the property is not writeable, or an attempt is made to set a property of primitive type to null, throw
        IllegalArgumentException.

      Notice the comment about setting a primitive property to null. This implies that a null value for this case
      is legal. The RI will only throw the NPE against a null value if there isn't an associated property.

      1. MYFACES-1681.patch
        3 kB
        Matthias Weßendorf

        Activity

        Ryan Lubke created issue -
        Ryan Lubke made changes -
        Field Original Value New Value
        Summary UICompone UIComponent.getAttributes() too restrictive
        Matthias Weßendorf made changes -
        Attachment MYFACES-1681.patch [ 12362112 ]
        Matthias Weßendorf made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Matthias Weßendorf made changes -
        Assignee Matthias Weßendorf [ matzew ]
        Matthias Weßendorf made changes -
        Fix Version/s 1.2.1-SNAPSHOT [ 12312571 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Matthias Weßendorf made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Matthias Weßendorf made changes -
        Affects Version/s 1.1.5 [ 12312310 ]
        Matthias Weßendorf made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Fix Version/s  1.1.6-SNAPSHOT [ 12312311 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.2.1 [ 12312895 ]
        Fix Version/s 1.2.1-SNAPSHOT [ 12312571 ]
        Fix Version/s  1.1.6-SNAPSHOT [ 12312311 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.2.1 [ 12312895 ]
        Fix Version/s 1.2.2 [ 12312932 ]

          People

          • Assignee:
            Matthias Weßendorf
            Reporter:
            Ryan Lubke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development