Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-1681

UIComponent.getAttributes() too restrictive

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1.5, 1.2.0
    • 1.2.2
    • JSR-252
    • None
    • SE 1.6.0_02
      GlassFish V2 admingui

    Description

      The Map returned by UIComponent.getAttributes() is too restrictive with respect
      to null values.

      MyFaces will always throw an NPE for a null value. Granted, the following is
      in the javadocs:

      • Any attempt to add a null key or value must throw a NullPointerException.

      However, the following is also in the same section:

      • put() - If the property is writeable, call the setter method to set the corresponding value (unwrapping primitive values in their
        corresponding wrapper classes). If the property is not writeable, or an attempt is made to set a property of primitive type to null, throw
        IllegalArgumentException.

      Notice the comment about setting a primitive property to null. This implies that a null value for this case
      is legal. The RI will only throw the NPE against a null value if there isn't an associated property.

      Attachments

        1. MYFACES-1681.patch
          3 kB
          Matthias Wessendorf

        Activity

          People

            matzew Matthias Wessendorf
            rlubke Ryan Lubke
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: