[MSHADE-434] Strange side-effect on rat-plugin

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.3.0
• Assignee: Unassigned
• Reporter: Chesnay Schepler
• Created: 24/Nov/22 17:31
• Updated: 13/Sep/24 18:56

Description

When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing anything else, the Apache Flink builds are getting failed by the rat-plugin, complaining about a number of files in the root target/ directory.

These files do exist, but are usually excluded by the plugin.
For some reason upgrading the shade-plugin is changing this behavior.

[WARNING] Files with unapproved licenses:
  /home/chesnay/dev/repos/flink/flink/target/rat.txt
  /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
  /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile

This is reeeeally strange, and were wondering if you guys have any ideas for what could going on here.

Interestingly enough explicitly listing these files (e.g., **/rat.txt) results in them being excluded again.

This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100% reproducible.

Issue Links

• is caused by: MSHADE-321 Always respect 'createDependencyReducedPom' flag
• relates to: FLINK-30083 Bump maven-shade-plugin to 3.4.1