Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-321

Always respect 'createDependencyReducedPom' flag

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.2.1
    • 3.3.0
    • None

    Description

       

      Dependency reduced pom (DRP) is generated only if resulting shaded artifact was 'renamed'

      https://github.com/apache/maven-shade-plugin/blob/dbd2a5c04619da76559c61c58755e7062fb8fab9/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L536

      However, the documentation regarding DRP states:

      Flag whether to generate a simplified POM for the shaded artifact. If set to true, dependencies that have been included into the uber JAR will be removed from the <dependencies> section of the generated POM. The reduced POM will be named dependency-reduced-pom.xml and is stored into the same directory as the shaded artifact. Unless you also specify dependencyReducedPomLocation, the plugin will create a temporary file named dependency-reduced-pom.xml in the project basedir.
      Default value is: true.

      It's not stating any changes in this flag behavior, by this hiding the conditions upon which DRP would be generated.

      This should be fixed, and DRP should be generated whenever the flag is being set to 'true'

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            michael-o Michael Osipov
            bkmz Ilya Cherkasov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 10m
              10m

              Slack

                Issue deployment