[MSHADE-239] Shaded Source JAR not following finalName pattern

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.4.3
• Fix Version/s: 3.0.0
• Assignee: Robert Scholte
• Reporter: Diego Rivera
• Created: 08/Nov/16 23:07
• Updated: 18/Jan/17 19:05
• Resolved: 18/Jan/17 18:51

Description

When enabling the <createSourcesJar> and <shadedSourcesContent> configurations, while also using a custom naming scheme in <finalName>, the sources JAR is named incorrectly.

For instance, given the following configuration:

<configuration>
    <finalName>${project.artifactId}-${project.version}-${some-other-crap}-exe</finalName>
    <createSourcesJar>true</createSourcesJar>
    <shadedSourcesContent>true</shadedSourcesContent>
    <shadedArtifactAttached>true</shadedArtifactAttached>
    <shadedClassifierName>exe</shadedClassifierName>
</configuration>

The shaded artifact is appropriately named artifact-version-crapola-exe.jar, while the source jar is named artifact-version-exe-sources.jar (note the missing "-crapola", from the variable ${some-other-crap} in <finalName>). The correct name should be artifact-version-crapola-exe-sources.jar (i.e. ${finalName}-sources.jar).

As a side note: it might be a good idea to enable the use of a ${shadedClassifierName} variable that can be referenced and interpolated within the <finalName> evaluation.