Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-239

Shaded Source JAR not following finalName pattern

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 3.0.0
    • Labels:
      None

      Description

      When enabling the <createSourcesJar> and <shadedSourcesContent> configurations, while also using a custom naming scheme in <finalName>, the sources JAR is named incorrectly.

      For instance, given the following configuration:

      <configuration>
          <finalName>${project.artifactId}-${project.version}-${some-other-crap}-exe</finalName>
          <createSourcesJar>true</createSourcesJar>
          <shadedSourcesContent>true</shadedSourcesContent>
          <shadedArtifactAttached>true</shadedArtifactAttached>
          <shadedClassifierName>exe</shadedClassifierName>
      </configuration>
      

      The shaded artifact is appropriately named artifact-version-crapola-exe.jar, while the source jar is named artifact-version-exe-sources.jar (note the missing "-crapola", from the variable ${some-other-crap} in <finalName>). The correct name should be artifact-version-crapola-exe-sources.jar (i.e. ${finalName}-sources.jar).

      As a side note: it might be a good idea to enable the use of a ${shadedClassifierName} variable that can be referenced and interpolated within the <finalName> evaluation.

        Attachments

          Activity

            People

            • Assignee:
              rfscholte Robert Scholte
              Reporter:
              diego.rivera.cr@gmail.com Diego Rivera
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: