Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-182

ServicesResourceTransformer incorrectly ignores given Relocators

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3
    • 3.0.0
    • None

    Description

      When using the ServicesResourceTransformer in conjunction with relocators for classes that have META-INF/services/ entries, the behavior of the Shade Plugin is unexpected because those services files entries do not get relocated.

      For example:

      Relocator: org.foo.Clazz to org.foo.shaded.Clazz
      Services files: META-INF/services/org.foo.Clazz

      We would expect a services file at META-INF/services/org.foo.shaded.Clazz in the shaded jar, but that does not happen (the file remains at META-INF/services/org.foo.Clazz) since the ServicesResourceTransformer ignores the given Relocators.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aheritier Arnaud Heritier
            thomas_kielbus Thomas Kielbus
            Votes:
            11 Vote for this issue
            Watchers:
            21 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment