Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-182

ServicesResourceTransformer incorrectly ignores given Relocators

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3
    • 3.0.0
    • None

    Description

      When using the ServicesResourceTransformer in conjunction with relocators for classes that have META-INF/services/ entries, the behavior of the Shade Plugin is unexpected because those services files entries do not get relocated.

      For example:

      Relocator: org.foo.Clazz to org.foo.shaded.Clazz
      Services files: META-INF/services/org.foo.Clazz

      We would expect a services file at META-INF/services/org.foo.shaded.Clazz in the shaded jar, but that does not happen (the file remains at META-INF/services/org.foo.Clazz) since the ServicesResourceTransformer ignores the given Relocators.

      Attachments

        1. MSHADE-182.patch
          3 kB
        2. MSHADE-182.patch
          2 kB
        3. MSHADE-182-test.patch
          4 kB

        Issue Links

          Activity

            People

              aheritier Arnaud Heritier
              thomas_kielbus Thomas Kielbus
              Votes:
              11 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: