[MNG-7563] REGRESSION: User properties now override model properties in dependencies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.8.5, 3.8.6
• Fix Version/s: 3.8.7, 3.9.0, 4.0.0-alpha-4, 4.0.0
• Component/s: Dependencies, POM
• Flags: Important
• Assignee: Michael Osipov
• Reporter: Hervé Guillemet
• Created: 13/Oct/22 03:14
• Updated: 20/Dec/22 08:27
• Resolved: 20/Dec/22 08:27

Description

An important change has been introduced in 3.8.5 that breaks some existing builds: Java system properties now take precedence over default values of user properties in dependency POMs. This look like a bug since it's now easy to affect dependency behaviors with system properties, a practice that has been discouraged. But maybe do you consider this as a new feature ?

As an example, 3 poms are attached to this ticket.
After installing projects b and c, building project a with:
mvn package -Ddep=x
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and 3.8.6 (-D override the default).

Note that without the setting of the default value for property dep in project b, the build fails with any version of Maven.

Issue Links

• causes: MNG-7635 Investigate how to safely propagate user properties to dependencies (see MNG-5982 and MNG-7417)
• is caused by: MNG-7417 Several classes do not set properties properly for building requests
• is fixed by: MNG-7634 Revert MNG-5982 and MNG-7417
• relates to: MNG-5982 The POM for ... is invalid, transitive dependencies ... while property was overriden