[MNG-7316] REGRESSION: MavenProject.getAttachedArtifacts() is read-only

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.8.2, 3.8.3
• Fix Version/s: 3.8.7, 3.9.0
• Component/s: Core
• External issue URL: https://github.com/apache/maven/pull/601
• Assignee: Michael Osipov
• Reporter: Gary D. Gregory
• Created: 23/Oct/21 20:36
• Updated: 18/Dec/22 14:04
• Resolved: 18/Dec/22 14:04

Description

The method MavenProject.getAttachedArtifacts() as of 3.8.2 breaks releasing components for us at Apache Commons using our Maven Release plugin because the list returned is now immutable, we now get an exception when calling remove() on the collection returned by the API; see https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137

This worked fine in 3.8.1, may you please change it back for 3.8.4?

We cannot use Maven 3.8.2 and 3.8.3 to release our components.

(michael-o: Ironically, I discovered this trying to create a release candidate for Apache Commons CLI.)

The exception in 3.8.3:

Caused by: java.lang.UnsupportedOperationException
at java.util.Collections$UnmodifiableCollection.remove (Collections.java:1060)
at org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute (CommonsDistributionDetachmentMojo.java:136)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)

 

Issue Links

• is broken by: MNG-5868 Adding several times the same artifact via MavenProjectHelper (attachArtifact) keep adding to the List duplicate artifacts
• is fixed by: MNG-7636 Partially revert MNG-5868 to restore backward compatibility (see MNG-7316)
• relates to: MNG-5384 Declarative artifacts
• links to: GitHub Pull Request #601