[MNG-5440] default-value on mojo parameter of type collection or array effectively make parameter read-only

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.9
• Assignee: Robert Scholte
• Reporter: Jan Sievers
• Created: 25/Feb/13 08:57
• Updated: 24/Dec/20 01:55
• Resolved: 12/Aug/16 15:48

Description

If you use default-value on collection or array mojo parameters like

    /**
     * @parameter default-value="foo,bar"
     */
    private List<String> param1;

the default value will always win over pom.xml configuration.
See demo project attached.
Steps to reproduce:

1. mvn install on the demo project
2. mvn compile -f test-pom.xml -X -e on the demo project

you can see in the debug log that mojo configuration

[DEBUG] Configuration: <?xml version="1.0" encoding="UTF-8"?>
<configuration>
  <param1 default-value="foo,bar">
    <param1>non-default value1 param1</param1>
    <param1>non-default value2 param1</param1>
  </param1>
  <param2 default-value="baz">
    <param2>non-default value1 param2</param2>
    <param2>non-default value2 param2</param2>
  </param2>
</configuration>

will not be aplied correctly:

[DEBUG] Configuring mojo 'mojoParamsBug:mojoParamsBug:0.0.1-SNAPSHOT:demo' with basic configurator -->
[DEBUG]   (f) param1 = [foo, bar]
[DEBUG]   (f) param2 = [baz]
[DEBUG] -- end configuration --
[INFO] param1: [foo, bar]
[INFO] param2: [baz]

If default values for srrays/collection are not supported, this should fail the build in step 1. above.
If they are supported, the configurator should be fixed to actually allow configuring non-default values.

Issue Links

• is depended upon by: MPMD-212 Add documentation and IT for MPMD-206
• is related to: MNG-5001 @readonly Mojo parameter annotation doesn't work any more
• is related to: MPLUGINTESTING-53 default-value on mojo parameter of type collection or array effectively make parameter read-only
• relates to: MPLUGIN-271 Usage of defaultValues for a List<..> Parameter seemed not to be working