Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5440

default-value on mojo parameter of type collection or array effectively make parameter read-only

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.9
    • Component/s: None
    • Labels:
      None

      Description

      If you use default-value on collection or array mojo parameters like

          /**
           * @parameter default-value="foo,bar"
           */
          private List<String> param1;
      

      the default value will always win over pom.xml configuration.
      See demo project attached.
      Steps to reproduce:

      1. mvn install on the demo project
      2. mvn compile -f test-pom.xml -X -e on the demo project

      you can see in the debug log that mojo configuration

      [DEBUG] Configuration: <?xml version="1.0" encoding="UTF-8"?>
      <configuration>
        <param1 default-value="foo,bar">
          <param1>non-default value1 param1</param1>
          <param1>non-default value2 param1</param1>
        </param1>
        <param2 default-value="baz">
          <param2>non-default value1 param2</param2>
          <param2>non-default value2 param2</param2>
        </param2>
      </configuration>

      will not be aplied correctly:

      [DEBUG] Configuring mojo 'mojoParamsBug:mojoParamsBug:0.0.1-SNAPSHOT:demo' with basic configurator -->
      [DEBUG]   (f) param1 = [foo, bar]
      [DEBUG]   (f) param2 = [baz]
      [DEBUG] -- end configuration --
      [INFO] param1: [foo, bar]
      [INFO] param2: [baz]

      If default values for srrays/collection are not supported, this should fail the build in step 1. above.
      If they are supported, the configurator should be fixed to actually allow configuring non-default values.

        Attachments

        1. mojoParamsBug.zip
          11 kB
          Jan Sievers

          Issue Links

            Activity

              People

              • Assignee:
                rfscholte Robert Scholte
                Reporter:
                jan.sievers Jan Sievers
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: