Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-9896

Consider using protobuf provided json conversion facilities rather than custom ones.

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Accepted
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: stout
    • Labels:

      Description

      Currently, stout provides custom JSON to protobuf conversion facilities, some of which use protobuf reflection.

      When upgrading protobuf to 3.7.x in MESOS-9755, we found that the v0 /state response of the master slowed down, and it appears to be due to a performance regression in the protobuf reflection code.

      We should file an issue with protobuf, but we should also look into using the json conversion code that protobuf provides to see if that can help avoid the regression. It may be the case that using the built-in facilities actually provides a significant performance benefit, given they don't use reflection.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                bmahler Benjamin Mahler
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: