[MESOS-9896] Consider using protobuf provided json conversion facilities rather than custom ones.

• Type: Task
• Status: Accepted
• Priority: Major
• Resolution: Unresolved
• Component/s: stout
• Labels: foundations
• Assignee: Unassigned
• Reporter: Benjamin Mahler
• Created: 17/Jul/19 17:23
• Updated: 08/Nov/19 21:40

Description

Currently, stout provides custom JSON to protobuf conversion facilities, some of which use protobuf reflection.

When upgrading protobuf to 3.7.x in MESOS-9755, we found that the v0 /state response of the master slowed down, and it appears to be due to a performance regression in the protobuf reflection code.

We should file an issue with protobuf, but we should also look into using the json conversion code that protobuf provides to see if that can help avoid the regression. It may be the case that using the built-in facilities actually provides a significant performance benefit, given they don't use reflection.

Issue Links

• is duplicated by: MESOS-9913 Use built-in protobuf JSON mapping utilities in favor of reflection for (de)serialization.
• is related to: MESOS-8727 JSON -> protobuf conversion in stout handles duplicated keys in a map incorrectly
• is related to: MESOS-3449 Expand the range of integer precision in json <-> protobuf conversions to include unsigned integers
• is related to: MESOS-9901 jsonify uses non-standard mapping for protobuf map fields.
• is related to: MESOS-6568 JSON serialization should not omit empty arrays in HTTP APIs
• relates to: MESOS-9755 Upgrade bundled protobuf to 3.7.x.
• links to: Protocol Buffers mailing list thread