Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-3449

Expand the range of integer precision in json <-> protobuf conversions to include unsigned integers

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 0.25.0
    • None
    • stout
    • 5

    Description

      The previous changes (MESOS-3345) to support integer precision when converting JSON <-> Protobuf did not support precision for unsigned integers between INT64_MAX and UINT64_MAX. (There's some loss, but the conversion is still as good/bad as it was with doubles.)

      This problem is due to a limitation in the JSON parsing library we use (PicoJSON), which parses integers as int64_t.

      Some possible solutions or things to investigate:

      • We can patch PicoJSON to parse some large values as uint64_t.
      • We can investigate using another parsing library.
      • If we want extra precision beyond 64 or 80 bits per double, one possibility is the GMP library. We'd still need to change the parsing library though.

      NOTE: The asV1Protobuf copy needs to also be updated.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kaysoky Joseph Wu
              Joris Van Remoortere Joris Van Remoortere
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: