[MESOS-3406] Should not update the framework info when framework->pid != from

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: James Wang
• Reporter: James Wang
• Created: 10/Sep/15 09:28
• Updated: 10/Sep/15 09:53
• Resolved: 10/Sep/15 09:53

Description

The current logic of Master::_subscribe as below:

if (frameworks.registered.contains(frameworkInfo.id())) {
    framework->updateFrameworkInfo(frameworkInfo);
    allocator->updateFramework(framework->id(), framework->info);

    framework->reregisteredTime = Clock::now();
    .....
    .....
    if (subscribe.force()) {
        ......
     } else if (framework->pid != from) {
         LOG(ERROR) << "Disallowing subscription attempt of"
                 << " framework " << *framework
                 << " because it is not expected from " << from;
          FrameworkErrorMessage message;
          message.set_message("Framework failed over");
          send(from, message);
     } else {
         ......
     }

In case if this framework has already registered but its pid does not equals with from, Master will send a "Framework failed over" message to framework to reject this register, but the framework info still be updated, I think this should be a bug, and in the failed register case, It should not update the framework info.

Issue Links

• duplicates: MESOS-3169 FrameworkInfo should only be updated if the re-registration is valid