[MESOS-3169] FrameworkInfo should only be updated if the re-registration is valid

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.25.0
• Fix Version/s: 0.25.0
• Component/s: master
• Labels: framework master mesosphere tech-debt
• Target Version/s: 0.25.0
• Story Points: 2
• Assignee: Guangya Liu
• Reporter: Joris Van Remoortere
• Shepherd: Joris Van Remoortere
• Created: 29/Jul/15 08:00
• Updated: 26/Nov/18 12:20
• Resolved: 26/Nov/18 12:20

Description

See Ben Mahler's comment in https://reviews.apache.org/r/32961/
FrameworkInfo should not be updated if the re-registration is invalid. This can happen in a few cases under the branching logic, so this requires some refactoring.
Notice that a

FrameworkErrorMessage

can be generated both inside

else if (from != framework->pid)

as well as from inside

failoverFramework(framework, from);

Issue Links

• is duplicated by: MESOS-3406 Should not update the framework info when framework->pid != from