[MESOS-2590] Let the slave control the duration of the perf sampler instead of relying on a sleep command.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Labels: twitter
• Target Version/s: 0.23.0
• Sprint: Twitter Mesos Q1 Sprint 6
• Story Points: 3
• Assignee: Jie Yu
• Reporter: Jie Yu
• Created: 02/Apr/15 18:13
• Updated: 03/Apr/15 21:38
• Resolved: 03/Apr/15 21:38

Description

Right now, we use a sleep command to control the duration of perf sampling:

sudo perf stat -a -x, --log-fd 1 --pid 10940 -- sleep 10

This causes an additional process (i.e., the sleep process) to be forked and causes troubles for us to terminate the perf sampler once the slave exits (See MESOS-2462).

Seems that the additional sleep process is not necessary. The slave can just monitor the duration and send a SIGINT to the perf process when duration elapsed. This will cause the perf process to output the stats and terminate.

Issue Links

• blocks: MESOS-2462 Add option for Subprocess to set a death signal for the forked child