[MESOS-2462] Add option for Subprocess to set a death signal for the forked child

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.21.1
• Fix Version/s: 0.23.0
• Component/s: containerization
• Labels: twitter
• Target Version/s: 0.23.0
• Sprint: Twitter Mesos Q1 Sprint 6
• Story Points: 3
• Assignee: Jie Yu
• Reporter: Ian Downes
• Shepherd: Ian Downes
• Created: 06/Mar/15 22:25
• Updated: 26/Apr/17 16:54
• Resolved: 03/Apr/15 21:38

Description

Currently, children forked by the slave, including those through Subprocess, will continue running if the slave exits. For some processes, including helper processes like the fetcher, du, or perf, we'd like them to be terminated when the slave exits.

Add support to Subprocess to optionally set a DEATHSIG for the child, e.g., setting SIGTERM would mean the child would get SIGTERM when the slave terminates.

This can be done (after forking) with PR_SET_DEATHSIG. See "man prctl". It is preserved through an exec call.

Issue Links

• is blocked by: MESOS-2590 Let the slave control the duration of the perf sampler instead of relying on a sleep command.
• is related to: MESOS-2668 Slave fails to recover when there are still processes left in its cgroup