[MESOS-1686] URI query strings are preserved in local filename

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.19.1, 0.20.0
• Component/s: fetcher
• Labels: newbie
• Assignee: Unassigned
• Reporter: Mike Babineau
• Created: 08/Aug/14 00:05
• Updated: 21/Nov/17 01:04

Description

When launching a task that includes a URI, the resulting local filename includes the query string. I assume this is undesired.

Example:
http://builds.mycompany.com/myapp.jar?auth_token=abc123
is saved to
myapp.jar?auth_token=abc123

It appears the problem is that launcher/fetcher.cpp generates the local filename with os::basename(uri). While keeping everything right of the last "/" is appropriate for basenames of local paths, URIs should be handled differently.

Given the structure:
scheme://domain:port/path?query_string#fragment_id
we can probably get by with a function that returns basename(uri.path)

Not sure if that should live in the stout package or somewhere else. Happy to submit a patch if someone can tell me where to put the function.

Thanks in advance!

Issue Links

• is related to: MESOS-8250 Fetcher cache does not ignore query parameters in URIs
• is related to: MESOS-3367 Mesos fetcher does not extract archives for URI with parameters
• relates to: MESOS-1509 Use Content-Disposition filename (if available) when downloading HTTP URIs
• relates to: MESOS-4735 CommandInfo.URI should allow specifying target filename