[MESOS-1509] Use Content-Disposition filename (if available) when downloading HTTP URIs

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.18.0, 0.19.0, 0.20.0, 0.21.0
• Component/s: agent

Environment

Linux (but should be irrelevant)

• Assignee: Unassigned
• Reporter: Bjoern Metzdorf
• Created: 18/Jun/14 20:31
• Updated: 05/Dec/16 10:43

Description

Currently the slave stores downloaded HTTP URIs in filenames that are made up from the part after the last "/" in the URI (in src/launcher/fetcher.cpp:122):

path =  path::join(directory, path.substr(path.find_last_of("/") + 1));

The problem is that the query string is included in the filename and a URI like http://my.web.server/dynamic/resource.tar.gz?a=b results in a downloaded file named resource.tar.gz?a=b.

The curl maintainers faced the same problem and added this:

-J, --remote-header-name
              (HTTP) This option tells the -O, --remote-name option to use the server-specified Content-Disposition filename instead of extracting a filename from the URL.

Maybe Mesos could do the same if a Content-Disposition header exists.

Issue Links

• is related to: MESOS-1686 URI query strings are preserved in local filename
• is related to: MESOS-3367 Mesos fetcher does not extract archives for URI with parameters
• relates to: MESOS-4735 CommandInfo.URI should allow specifying target filename