[MDEPLOY-234] Nothing is deployed if deployAtEnd=true and extension is added in submodule

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.8.2
• Component/s: deploy:deploy
• Environment: Maven 3.5.3
• Assignee: Robert Scholte
• Reporter: Piotr Paczynski
• Created: 11/Apr/18 11:44
• Updated: 11/Apr/18 16:26
• Resolved: 11/Apr/18 16:26

Description

It seems that when deploytEnd=true and one of the submodules in the reactor adds an extension, then nothing gets deployed. The last module to build says "Deploying ... at end".

 

I'm attaching a minimal project that is affected by the issue. To reproduce, unpack it and issue the following command in the main dir (I've used Maven 3.5.3).

mvn deploy -DaltDeploymentRepository=test::default::file:target/repo

Outcome: Nothing is deployed. The target/repo is not created. See output attached.

Expected result: Deployment of both modules is performed during submodule's deploy phase.

 

I've debugged it and think I understand the problem:

1. When the parent module is built, the DeployMojo class is loaded and the

private static final AtomicInteger readyProjectsCounter

field is initialized to 0.

2. Then it's bumped to 1 when deploy of "parent" is executed.

3. Then, the second module is built (submodule) and, because it contributes an extension, DepoyMojo class is re-loaded (by Guice?) and the

private static final AtomicInteger readyProjectsCounter

field is reinitialized to 0.

4. Then it's bumped to 1 when deploy of "submodule" is executed, but since 1 < 2 the deploy is not performed at all.

 

Not sure how to fix it, anyone?

Issue Links

• duplicates: MDEPLOY-226 DeployAtEnd fails when module has extension