Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.21.0
    • 0.21.0
    • build
    • None
    • building on RHEL5 with both javadoc and findbugs in the same line

    • Reviewed
    • Changes the heapsize for findbugs to a parameter which can be changed on the build command line.

    Description

      When attempting the build with the hardcoded value of 512M for findbugs heap size, the build fails with:

      [findbugs] Java Result: -1
      [xslt] Processing /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.xml to /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.html
      [xslt] Loading stylesheet /homes/hadoopqa/tools/findbugs/latest/src/xsl/default.xsl
      [xslt] : Error! Premature end of file.
      [xslt] : Error! com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature end of file.
      [xslt] Failed to process /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.xml

      BUILD FAILED

      Attachments

        1. MAPRED-845.patch
          0.8 kB
          Lee Tucker

        Activity

          ltucker Lee Tucker added a comment -

          Parameterize the heap size for the findbugs command, setting the default to 512M as it's currently set.

          ltucker Lee Tucker added a comment - Parameterize the heap size for the findbugs command, setting the default to 512M as it's currently set.
          nidaley Nigel Daley added a comment -

          +1 code review.

          nidaley Nigel Daley added a comment - +1 code review.
          ltucker Lee Tucker added a comment -

          Results of a local run of test-patch:

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]

          ltucker Lee Tucker added a comment - Results of a local run of test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
          szetszwo Tsz-wo Sze added a comment -

          Just a question: after the patch, are we supposed to pass "-Dfindbugs.heap.size=..." when we run "ant findbugs"?

          szetszwo Tsz-wo Sze added a comment - Just a question: after the patch, are we supposed to pass "-Dfindbugs.heap.size=..." when we run "ant findbugs"?
          ltucker Lee Tucker added a comment -

          No need, I preserved the original value of 512M as the default. However, if needed you can override it on the command line.

          ltucker Lee Tucker added a comment - No need, I preserved the original value of 512M as the default. However, if needed you can override it on the command line.
          szetszwo Tsz-wo Sze added a comment -

          Since this is a build.xml change, no new test is needed.

          I have committed this. Thanks, Lee!

          szetszwo Tsz-wo Sze added a comment - Since this is a build.xml change, no new test is needed. I have committed this. Thanks, Lee!
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #46 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/46/)

          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #46 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/46/ )

          People

            ltucker Lee Tucker
            ltucker Lee Tucker
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2m
                2m
                Remaining:
                Remaining Estimate - 2m
                2m
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack