Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-845

build.xml hard codes findbugs heap size, in some configurations 512M is insufficient to successfully build

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      building on RHEL5 with both javadoc and findbugs in the same line

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Changes the heapsize for findbugs to a parameter which can be changed on the build command line.

      Description

      When attempting the build with the hardcoded value of 512M for findbugs heap size, the build fails with:

      [findbugs] Java Result: -1
      [xslt] Processing /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.xml to /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.html
      [xslt] Loading stylesheet /homes/hadoopqa/tools/findbugs/latest/src/xsl/default.xsl
      [xslt] : Error! Premature end of file.
      [xslt] : Error! com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature end of file.
      [xslt] Failed to process /grid/0/gs/gridre/SpringMapRedLevel2/build/test/findbugs/hadoop-findbugs-report.xml

      BUILD FAILED

        Activity

        Hide
        Lee Tucker added a comment -

        Parameterize the heap size for the findbugs command, setting the default to 512M as it's currently set.

        Show
        Lee Tucker added a comment - Parameterize the heap size for the findbugs command, setting the default to 512M as it's currently set.
        Hide
        Nigel Daley added a comment -

        +1 code review.

        Show
        Nigel Daley added a comment - +1 code review.
        Hide
        Lee Tucker added a comment -

        Results of a local run of test-patch:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]

        Show
        Lee Tucker added a comment - Results of a local run of test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Just a question: after the patch, are we supposed to pass "-Dfindbugs.heap.size=..." when we run "ant findbugs"?

        Show
        Tsz Wo Nicholas Sze added a comment - Just a question: after the patch, are we supposed to pass "-Dfindbugs.heap.size=..." when we run "ant findbugs"?
        Hide
        Lee Tucker added a comment -

        No need, I preserved the original value of 512M as the default. However, if needed you can override it on the command line.

        Show
        Lee Tucker added a comment - No need, I preserved the original value of 512M as the default. However, if needed you can override it on the command line.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Since this is a build.xml change, no new test is needed.

        I have committed this. Thanks, Lee!

        Show
        Tsz Wo Nicholas Sze added a comment - Since this is a build.xml change, no new test is needed. I have committed this. Thanks, Lee!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #46 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/46/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #46 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/46/ )

          People

          • Assignee:
            Lee Tucker
            Reporter:
            Lee Tucker
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2m
              2m
              Remaining:
              Remaining Estimate - 2m
              2m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development