[MAPREDUCE-7403] Support spark dynamic partitioning in the Manifest Committer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.5
• Fix Version/s: 3.4.0, 3.3.5
• Component/s: mrv2
• Labels: pull-request-available
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 09/Aug/22 14:14
• Updated: 09/Sep/22 16:06
• Resolved: 24/Aug/22 10:25

Description

Currently the spark integration with PathOutputCommitters rejects attempt to instantiate them if dynamic partitioning is enabled. That is because the spark partitioning code assumes that

1. file rename works as a fast and safe commit algorithm
2. the working directory is in the same FS as the final directory

Assumption 1 doesn't hold on s3a, and #2 isn't true for the staging committers.

The new abfs/gcs manifest committer and the target stores do meet both requirements. So we no longer need to reject the operation, provided the spark side binding-code can can identify when all is good.

Proposed: add a new hasCapability() probe which, if, a committer implements StreamCapabilities can be used to see if the committer will work. ManifestCommitter will declare that it holds. As the API has existed since 2.10, it will be immediately available.

spark's PathOutputCommitProtocol to query the committer in setupCommitter, and fail if dynamicPartitionOverwrite is requested but not available.

BindingParquetOutputCommitter to implement and forward StreamCapabilities.hasCapability.

Issue Links

• is related to: SPARK-40034 PathOutputCommitters to work with dynamic partition overwrite
• relates to: MAPREDUCE-7341 Add a task-manifest output committer for Azure and GCS
• links to: GitHub Pull Request #4728