[MAPREDUCE-7341] Add a task-manifest output committer for Azure and GCS

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.5
• Component/s: client
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 30/Apr/21 10:49
• Updated: 01/Jan/24 19:33
• Resolved: 17/Mar/22 11:50

Description

Add a task-manifest output committer for Azure and GCS

The S3A committers are very popular in Spark on S3, as they are both correct and fast.

The classic FileOutputCommitter v1 and v2 algorithms are all that is available for Azure ABFS and Google GCS, and they have limitations.

The v2 algorithm isn't safe in the presence of failed task attempt commits, so we
recommend the v1 algorithm for Azure. But that is slow because it sequentially lists
then renames files and directories, one-by-one. The latencies of list
and rename make things slow.

Google GCS lacks the atomic directory rename required for v1 correctness;
v2 can be used (which doesn't have the job commit performance limitations),
but it's not safe.

Proposed

• Add a new FileOutputFormat committer which uses an intermediate manifest to
  pass the list of files created by a TA to the job committer.
• Job committer to parallelise reading these task manifests and submit all the
  rename operations into a pool of worker threads. (also: mkdir, directory deletions on cleanup)
• Use the committer plugin mechanism added for s3a to make this the default committer for ABFS
  (i.e. no need to make any changes to FileOutputCommitter)
• Add lots of IOStatistics instrumentation + logging of operations in the JobCommit
  for visibility of where delays are occurring.
• Reuse the S3A committer _SUCCESS JSON structure to publish IOStats & other data
  for testing/support.

This committer will be faster than the V1 algorithm because of the parallelisation, and
because a manifest written by create-and-rename will be exclusive to a single task
attempt, delivers the isolation which the v2 committer lacks.

This is not an attempt to do an iceberg/hudi/delta-lake style manifest-only format
for describing the contents of a table; the final output is still a directory tree
which must be scanned during query planning.
As such the format is still suboptimal for cloud storage -but at least we will have
faster job execution during the commit phases.

Note: this will also work on HDFS, where again, it should be faster than
the v1 committer. However the target is very much Spark with ABFS and GCS; no plans to worry about MR as that simplifies the challenge of dealing with job restart (i.e. you don't have to)

Issue Links

• incorporates: HADOOP-18163 hadoop-azure support for the Manifest Committer of MAPREDUCE-7341
• incorporates: HADOOP-18162 hadoop-common enhancements for the Manifest Committer of MAPREDUCE-7341
• is blocked by: HADOOP-17979 Interface EtagSource to allow FileStatus subclasses to provide etags
• is depended upon by: HADOOP-17833 Improve Magic Committer Performance
• is related to: HADOOP-17691 Abfs directory delete times out on large directory tree w/ Oauth: OperationTimedOut
• is related to: HADOOP-17502 IOStatistics collection for listStatusIterator()
• is related to: HADOOP-18012 ABFS: Enable config controlled ETag check for Rename idempotency
• is related to: MAPREDUCE-7403 Support spark dynamic partitioning in the Manifest Committer
• is related to: AVRO-3266 Output stream incompatible with MagicS3GuardCommitter
• is related to: HADOOP-17981 Support etag-assisted renames in FileOutputCommitter
• is related to: MAPREDUCE-7465 performance problem in FileOutputCommitter for big list processed by single thread
• is related to: SPARK-40034 PathOutputCommitters to work with dynamic partition overwrite
• relates to: MAPREDUCE-7331 Make temporary directory used by FileOutputCommitter configurable
• supercedes: HADOOP-17274 MR FileInput/Output formats to aggregate IOStatistics
• supercedes: MAPREDUCE-7282 MR v2 commit algorithm should be deprecated and not the default
• supercedes: MAPREDUCE-7300 PathOutputCommitter to add method failedTaskAttemptCommitRecoverable()
• supercedes: MAPREDUCE-7366 FileOutputCommitter Enable Concurrent Writes
• Testing discovered: HADOOP-17906 AbstractAbfsIntegrationTest.createFilesystemForSASTests() leaks FS instances
• links to: GitHub Pull Request #2971
• links to: GitHub Pull Request #4075