Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6618

YarnClientProtocolProvider leaking the YarnClient thread.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      YarnClientProtocolProvider creates YarnRunner which includes ResourceMgrDelegate. In ResourceMgrDelegate, we would initiate and start yarnclient. The yarnClient thread would be leaked due to

        @Override
        public void close(ClientProtocol clientProtocol) throws IOException {
          // nothing to do
        }
      

      in YarnClientProtocolProvider

      1. MAPREDUCE-6618.1.patch
        2 kB
        Xuan Gong
      2. MAPREDUCE-6618.2.patch
        2 kB
        Xuan Gong
      3. MAPREDUCE-6618.3.patch
        5 kB
        Xuan Gong
      4. MAPREDUCE-6618.4.patch
        5 kB
        Xuan Gong
      5. MAPREDUCE-6618.5.patch
        5 kB
        Xuan Gong
      6. MAPREDUCE-6618.6.patch
        6 kB
        Xuan Gong

        Issue Links

          Activity

          Hide
          xgong Xuan Gong added a comment -

          The problem would be much worse if the ats v1.5 is enabled. In ats v1.5, we would create two timer tasks in TimelineClient. We would leak two more threads every time when we start YarnClient with TimelineClient enabled.

          Show
          xgong Xuan Gong added a comment - The problem would be much worse if the ats v1.5 is enabled. In ats v1.5, we would create two timer tasks in TimelineClient. We would leak two more threads every time when we start YarnClient with TimelineClient enabled.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 34s trunk passed
          +1 compile 0m 20s trunk passed with JDK v1.8.0_66
          +1 compile 0m 23s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 28s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 17s the patch passed with JDK v1.8.0_66
          +1 javac 0m 17s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.7.0_91
          +1 javac 0m 20s the patch passed
          -1 checkstyle 0m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: patch generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28)
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 1s Patch has no whitespace issues.
          -1 findbugs 0m 37s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91
          -1 unit 110m 15s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 116m 34s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 28s Patch generated 15 ASF License warnings.
          241m 18s



          Reason Tests
          FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
            Field only ever set to null:null: org.apache.hadoop.mapred.YarnClientProtocolProvider.yarnRunner In YarnClientProtocolProvider.java
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784282/MAPREDUCE-6618.1.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 76ba0dfd858a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2085e60
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
          findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.html
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 34s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_66 +1 compile 0m 23s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 23s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_66 +1 javac 0m 17s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_91 +1 javac 0m 20s the patch passed -1 checkstyle 0m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: patch generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. -1 findbugs 0m 37s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91 -1 unit 110m 15s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 116m 34s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 28s Patch generated 15 ASF License warnings. 241m 18s Reason Tests FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient   Field only ever set to null:null: org.apache.hadoop.mapred.YarnClientProtocolProvider.yarnRunner In YarnClientProtocolProvider.java JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784282/MAPREDUCE-6618.1.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 76ba0dfd858a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2085e60 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.html unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6283/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          In this patch I'm confused on how the changes to the protocol provider accomplish anything. There's a new variable, yarnRunner, initialized to null and set nowhere else. In the close method it checks it for non-null before doing anything, but how can it be anything but null? Note that a single protocol provider can create multiple clients, so having the protocol provider track a single YARNRunner client does not seem appropriate.

          The close method is handed the object to cleanup, namely clientProtocol, but it's ignoring it even in the proposed patch. It needs to cast that to a YARNRunner and close that object.

          Show
          jlowe Jason Lowe added a comment - In this patch I'm confused on how the changes to the protocol provider accomplish anything. There's a new variable, yarnRunner, initialized to null and set nowhere else. In the close method it checks it for non-null before doing anything, but how can it be anything but null? Note that a single protocol provider can create multiple clients, so having the protocol provider track a single YARNRunner client does not seem appropriate. The close method is handed the object to cleanup, namely clientProtocol, but it's ignoring it even in the proposed patch. It needs to cast that to a YARNRunner and close that object.
          Hide
          xgong Xuan Gong added a comment -

          Jason Lowe

          The close method is handed the object to cleanup, namely clientProtocol, but it's ignoring it even in the proposed patch. It needs to cast that to a YARNRunner and close that object.

          This sounds like the appropriate solution for this issue.

          Attached a patch to address the comments.

          Show
          xgong Xuan Gong added a comment - Jason Lowe The close method is handed the object to cleanup, namely clientProtocol, but it's ignoring it even in the proposed patch. It needs to cast that to a YARNRunner and close that object. This sounds like the appropriate solution for this issue. Attached a patch to address the comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 53s trunk passed
          +1 compile 0m 19s trunk passed with JDK v1.8.0_66
          +1 compile 0m 23s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 18s the patch passed with JDK v1.8.0_66
          +1 javac 0m 18s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.7.0_91
          +1 javac 0m 20s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 36s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91
          -1 unit 102m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 105m 37s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 15 ASF License warnings.
          222m 43s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.TestYarnClientProtocolProvider
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.TestYarnClientProtocolProvider



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784452/MAPREDUCE-6618.2.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2cdfaebf04b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0d7c22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 53s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 23s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 23s the patch passed +1 compile 0m 18s the patch passed with JDK v1.8.0_66 +1 javac 0m 18s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_91 +1 javac 0m 20s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91 -1 unit 102m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 105m 37s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 15 ASF License warnings. 222m 43s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.TestYarnClientProtocolProvider JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.TestYarnClientProtocolProvider Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784452/MAPREDUCE-6618.2.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2cdfaebf04b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0d7c22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6285/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Patch looks better, thanks! What about the client cache that's also in YARNRunner? It potentially has a history server client that I think also should be closed in this case.

          Show
          jlowe Jason Lowe added a comment - Patch looks better, thanks! What about the client cache that's also in YARNRunner? It potentially has a history server client that I think also should be closed in this case.
          Hide
          xgong Xuan Gong added a comment -

          Thanks for the comments. Jason Lowe.

          Attached a new patch to address the comment

          Show
          xgong Xuan Gong added a comment - Thanks for the comments. Jason Lowe . Attached a new patch to address the comment
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 49s trunk passed
          +1 compile 0m 42s trunk passed with JDK v1.8.0_66
          +1 compile 0m 21s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 28s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 11s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 21s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.8.0_66
          +1 javac 0m 15s the patch passed
          +1 compile 0m 19s the patch passed with JDK v1.7.0_91
          +1 javac 0m 19s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 33s the patch passed
          +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 11s the patch passed with JDK v1.7.0_91
          -1 unit 102m 23s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 101m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 19 ASF License warnings.
          218m 37s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapreduce.TestYarnClientProtocolProvider
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.TestYarnClientProtocolProvider
            hadoop.mapred.TestNetworkedJob



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784527/MAPREDUCE-6618.3.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 92e97d407f40 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cf8af7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 49s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_66 +1 compile 0m 21s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 11s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 21s the patch passed +1 compile 0m 15s the patch passed with JDK v1.8.0_66 +1 javac 0m 15s the patch passed +1 compile 0m 19s the patch passed with JDK v1.7.0_91 +1 javac 0m 19s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_91 -1 unit 102m 23s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 101m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 19 ASF License warnings. 218m 37s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapreduce.TestYarnClientProtocolProvider   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.TestYarnClientProtocolProvider   hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784527/MAPREDUCE-6618.3.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 92e97d407f40 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cf8af7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6287/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! Couple of nits:

          Should we be setting fields to null as we check them for non-null and close them?

          Is there a reason we use entrySet() instead of values() here? It ignores the job IDs, so thinking we don't need the full entry set.

                for (Entry<JobID, ClientServiceDelegate> delegate : cache.entrySet()) {
                  ClientServiceDelegate jobDelegate = delegate.getValue();
                  if (jobDelegate != null) {
                    jobDelegate.close();
                  }
                }
          
          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! Couple of nits: Should we be setting fields to null as we check them for non-null and close them? Is there a reason we use entrySet() instead of values() here? It ignores the job IDs, so thinking we don't need the full entry set. for (Entry<JobID, ClientServiceDelegate> delegate : cache.entrySet()) { ClientServiceDelegate jobDelegate = delegate.getValue(); if (jobDelegate != null ) { jobDelegate.close(); } }
          Hide
          xgong Xuan Gong added a comment -

          Jason Lowe
          Thanks for the comments.

          I have remove one un-necessary null check for

            private Map<JobID, ClientServiceDelegate> cache = 
                new HashMap<JobID, ClientServiceDelegate>();
          

          in ClientCache.java

          And set fields to null initially for the un-final variables.

          Attached a new patch for this.

          Show
          xgong Xuan Gong added a comment - Jason Lowe Thanks for the comments. I have remove one un-necessary null check for private Map<JobID, ClientServiceDelegate> cache = new HashMap<JobID, ClientServiceDelegate>(); in ClientCache.java And set fields to null initially for the un-final variables. Attached a new patch for this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 31s trunk passed
          +1 compile 0m 19s trunk passed with JDK v1.8.0_66
          +1 compile 0m 23s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 27s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 17s the patch passed with JDK v1.8.0_66
          +1 javac 0m 17s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.7.0_91
          +1 javac 0m 20s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_91
          -1 unit 102m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 105m 7s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 26s Patch generated 15 ASF License warnings.
          221m 37s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.TestYarnClientProtocolProvider
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.TestYarnClientProtocolProvider



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784680/MAPREDUCE-6618.4.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7303174f8d53 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 97056c3
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 31s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 23s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 23s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_66 +1 javac 0m 17s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_91 +1 javac 0m 20s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_91 -1 unit 102m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 105m 7s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 26s Patch generated 15 ASF License warnings. 221m 37s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.TestYarnClientProtocolProvider JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.TestYarnClientProtocolProvider Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784680/MAPREDUCE-6618.4.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7303174f8d53 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 97056c3 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6288/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Sorry, I should have been more clear. I don't think we need to initialize these various fields to null because that's what Java does automatically. (Doesn't hurt, just not sure it helps anything.) Instead what I was asking was whether it would be prudent to set things to null as we close them. For example, a code idiom like this template:

            if (x != null) {
              x.close();
              x = null;
            }
          

          This helps guard against doing extra work in cases of a double-close or someone trying to continue using the object after it has been closed. I'm simply used to seeing that sort of pattern, so when I saw the code checking for null before the close I wondered out loud whether we should be also setting the fields to null as part of that close processing.

          Show
          jlowe Jason Lowe added a comment - Sorry, I should have been more clear. I don't think we need to initialize these various fields to null because that's what Java does automatically. (Doesn't hurt, just not sure it helps anything.) Instead what I was asking was whether it would be prudent to set things to null as we close them. For example, a code idiom like this template: if (x != null ) { x.close(); x = null ; } This helps guard against doing extra work in cases of a double-close or someone trying to continue using the object after it has been closed. I'm simply used to seeing that sort of pattern, so when I saw the code checking for null before the close I wondered out loud whether we should be also setting the fields to null as part of that close processing.
          Hide
          xgong Xuan Gong added a comment -

          Jason Lowe
          Thanks for the clarification. The new patch addressed that.

          Show
          xgong Xuan Gong added a comment - Jason Lowe Thanks for the clarification. The new patch addressed that.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 26s trunk passed
          +1 compile 0m 52s trunk passed with JDK v1.8.0_66
          +1 compile 0m 39s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 49s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 0m 46s trunk passed
          +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 22s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 40s the patch passed
          +1 compile 0m 48s the patch passed with JDK v1.8.0_66
          +1 javac 0m 48s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.7.0_91
          +1 javac 0m 35s the patch passed
          -1 checkstyle 0m 19s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: patch generated 1 new + 78 unchanged - 0 fixed = 79 total (was 78)
          +1 mvnsite 0m 42s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 0s the patch passed
          +1 javadoc 0m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_91
          -1 unit 172m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 151m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 37s Patch generated 15 ASF License warnings.
          350m 46s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapreduce.v2.TestRMNMInfo
            hadoop.mapred.TestMRTimelineEventHandling
            hadoop.mapreduce.TestYarnClientProtocolProvider
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob
            hadoop.mapred.TestMRTimelineEventHandling
            hadoop.mapreduce.TestYarnClientProtocolProvider
            hadoop.mapred.TestLocalMRNotification
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785023/MAPREDUCE-6618.5.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b082b414367c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 61382ff
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 26s trunk passed +1 compile 0m 52s trunk passed with JDK v1.8.0_66 +1 compile 0m 39s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 0m 46s trunk passed +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 40s the patch passed +1 compile 0m 48s the patch passed with JDK v1.8.0_66 +1 javac 0m 48s the patch passed +1 compile 0m 35s the patch passed with JDK v1.7.0_91 +1 javac 0m 35s the patch passed -1 checkstyle 0m 19s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: patch generated 1 new + 78 unchanged - 0 fixed = 79 total (was 78) +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_91 -1 unit 172m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 151m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 37s Patch generated 15 ASF License warnings. 350m 46s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapreduce.v2.TestRMNMInfo   hadoop.mapred.TestMRTimelineEventHandling   hadoop.mapreduce.TestYarnClientProtocolProvider JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob   hadoop.mapred.TestMRTimelineEventHandling   hadoop.mapreduce.TestYarnClientProtocolProvider   hadoop.mapred.TestLocalMRNotification JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785023/MAPREDUCE-6618.5.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b082b414367c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 61382ff Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6295/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Could you look into the failed unit tests? I'm not sure about the others, but the TestYarnClientProtocolProvider failure looks related. Also would be nice to cleanup the now unused import. Otherwise patch looks good.

          Show
          jlowe Jason Lowe added a comment - Could you look into the failed unit tests? I'm not sure about the others, but the TestYarnClientProtocolProvider failure looks related. Also would be nice to cleanup the now unused import. Otherwise patch looks good.
          Hide
          xgong Xuan Gong added a comment -

          Jason Lowe
          Fix the TestYarnClientProtocolProvider failure.
          Create https://issues.apache.org/jira/browse/MAPREDUCE-6623 for other test failures.

          attached a new patch to address all the comments

          Show
          xgong Xuan Gong added a comment - Jason Lowe Fix the TestYarnClientProtocolProvider failure. Create https://issues.apache.org/jira/browse/MAPREDUCE-6623 for other test failures. attached a new patch to address all the comments
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 18s trunk passed
          +1 compile 0m 20s trunk passed with JDK v1.8.0_66
          +1 compile 0m 22s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 26s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.7.0_91
          +1 javac 0m 20s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 35s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91
          -1 unit 101m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          -1 unit 104m 45s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 25s Patch generated 15 ASF License warnings.
          220m 18s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785243/MAPREDUCE-6618.6.patch
          JIRA Issue MAPREDUCE-6618
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a0657fc6512d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c9a09d6
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 18s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_66 +1 compile 0m 22s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 23s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_91 +1 javac 0m 20s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_91 -1 unit 101m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. -1 unit 104m 45s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 15 ASF License warnings. 220m 18s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785243/MAPREDUCE-6618.6.patch JIRA Issue MAPREDUCE-6618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a0657fc6512d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c9a09d6 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6299/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Xuan! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.

          Show
          jlowe Jason Lowe added a comment - Thanks, Xuan! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9215 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9215/)
          MAPREDUCE-6618. YarnClientProtocolProvider leaking the YarnClient (jlowe: rev 59a212b6e1265adfa9b55c71b65a22157dfccf77)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9215 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9215/ ) MAPREDUCE-6618 . YarnClientProtocolProvider leaking the YarnClient (jlowe: rev 59a212b6e1265adfa9b55c71b65a22157dfccf77) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              xgong Xuan Gong
              Reporter:
              xgong Xuan Gong
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development