Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5309

Fix SSLFactory truststore reloader thread leak in TimelineClientImpl

    Details

    • Target Version/s:

      Description

      We found a similar issue as HADOOP-11368 in TimelineClientImpl. The class creates an instance of SSLFactory in newSslConnConfigurator and subsequently creates the ReloadingX509TrustManager instance which in turn starts a trust store reloader thread.
      However, the SSLFactory is never destroyed and hence the trust store reloader threads are not killed.

      This problem was observed by a customer who had SSL enabled in Hadoop and submitted many queries against the HiveServer2. After a few days, the HS2 instance crashed and from the Java dump we could see many (over 13000) threads like this:
      "Truststore reloader thread" #126 daemon prio=5 os_prio=0 tid=0x00007f680d2e3000 nid=0x98fd waiting on
      condition [0x00007f67e482c000]
      java.lang.Thread.State: TIMED_WAITING (sleeping)
      at java.lang.Thread.sleep(Native Method)
      at org.apache.hadoop.security.ssl.ReloadingX509TrustManager.run
      (ReloadingX509TrustManager.java:225)
      at java.lang.Thread.run(Thread.java:745)

      HiveServer2 uses the JobClient to submit a job:
      Thread [HiveServer2-Background-Pool: Thread-188] (Suspended (breakpoint at line 89 in

      ReloadingX509TrustManager))
      owns: Object (id=464)
      owns: Object (id=465)
      owns: Object (id=466)
      owns: ServiceLoader<S> (id=210)
      ReloadingX509TrustManager.<init>(String, String, String, long) line: 89
      FileBasedKeyStoresFactory.init(SSLFactory$Mode) line: 209
      SSLFactory.init() line: 131
      TimelineClientImpl.newSslConnConfigurator(int, Configuration) line: 532
      TimelineClientImpl.newConnConfigurator(Configuration) line: 507
      TimelineClientImpl.serviceInit(Configuration) line: 269
      TimelineClientImpl(AbstractService).init(Configuration) line: 163
      YarnClientImpl.serviceInit(Configuration) line: 169
      YarnClientImpl(AbstractService).init(Configuration) line: 163
      ResourceMgrDelegate.serviceInit(Configuration) line: 102
      ResourceMgrDelegate(AbstractService).init(Configuration) line: 163
      ResourceMgrDelegate.<init>(YarnConfiguration) line: 96
      YARNRunner.<init>(Configuration) line: 112
      YarnClientProtocolProvider.create(Configuration) line: 34
      Cluster.initialize(InetSocketAddress, Configuration) line: 95
      Cluster.<init>(InetSocketAddress, Configuration) line: 82
      Cluster.<init>(Configuration) line: 75
      JobClient.init(JobConf) line: 475
      JobClient.<init>(JobConf) line: 454
      MapRedTask(ExecDriver).execute(DriverContext) line: 401
      MapRedTask.execute(DriverContext) line: 137
      MapRedTask(Task<T>).executeTask() line: 160
      TaskRunner.runSequential() line: 88
      Driver.launchTask(Task<Serializable>, String, boolean, String, int, DriverContext) line: 1653
      Driver.execute() line: 1412

      For every job, a new instance of JobClient/YarnClientImpl/TimelineClientImpl is created. But because the HS2 process stays up for days, the previous trust store reloader threads are still hanging around in the HS2 process and eventually use all the resources available.

      It seems like a similar fix as HADOOP-11368 is needed in TimelineClientImpl but it doesn't have a destroy method to begin with.

      One option to avoid this problem is to disable the yarn timeline service (yarn.timeline-service.enabled=false).

      1. YARN-5309.001.patch
        3 kB
        Weiwei Yang
      2. YARN-5309.002.patch
        6 kB
        Weiwei Yang
      3. YARN-5309.003.patch
        6 kB
        Weiwei Yang
      4. YARN-5309.004.patch
        6 kB
        Weiwei Yang
      5. YARN-5309.005.patch
        7 kB
        Weiwei Yang
      6. YARN-5309.branch-2.7.3.001.patch
        7 kB
        Weiwei Yang
      7. YARN-5309.branch-2.8.001.patch
        7 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment - - edited

          Hello Thomas Friedrich

          Good catch! I think we should destroy sslFactory in serviceStop(), I uploaded a simple patch to do so. Can you please check if this patch resolves the problem? I will add a test case shortly. (I assign this one to myself as I found I can't upload a patch if it is unassigned).

          Show
          cheersyang Weiwei Yang added a comment - - edited Hello Thomas Friedrich Good catch! I think we should destroy sslFactory in serviceStop() , I uploaded a simple patch to do so. Can you please check if this patch resolves the problem? I will add a test case shortly. (I assign this one to myself as I found I can't upload a patch if it is unassigned).
          Hide
          tfriedr Thomas Friedrich added a comment -

          Hi Wei Wei,
          Unfortunately the serviceStop method on the ResourceMgrDelegate is not called by the YarnRunner when the job is done. That's why the serviceStop in the TimelineClientImpl won't be triggered either. I think your change is necessary regardless, but we need an additional change to initiate the clean-up when the job is done.

          Show
          tfriedr Thomas Friedrich added a comment - Hi Wei Wei, Unfortunately the serviceStop method on the ResourceMgrDelegate is not called by the YarnRunner when the job is done. That's why the serviceStop in the TimelineClientImpl won't be triggered either. I think your change is necessary regardless, but we need an additional change to initiate the clean-up when the job is done.
          Hide
          cheersyang Weiwei Yang added a comment - - edited

          Hello Thomas Friedrich

          If JobClient.close() is called, then it will eventually call TimelineClientImpl.serviceStop(), I have verified this in debug mode. So did hive call the close() method ? Also I noticed from MAPREDUCE-6431, JobClient implements AutoCloseable interface now, so if the instance is declared within try-with-resources block, the close() method will be automatically called (instead of in a finally block), it would be good to leverage this change in hive's code too.

          Show
          cheersyang Weiwei Yang added a comment - - edited Hello Thomas Friedrich If JobClient.close() is called, then it will eventually call TimelineClientImpl.serviceStop() , I have verified this in debug mode. So did hive call the close() method ? Also I noticed from MAPREDUCE-6431 , JobClient implements AutoCloseable interface now, so if the instance is declared within try-with-resources block, the close() method will be automatically called (instead of in a finally block), it would be good to leverage this change in hive's code too.
          Hide
          cheersyang Weiwei Yang added a comment -

          Attach v2 patch, added unit test. See TestTimelineClient#testTimelineClientCleanup, without the fix in TimelineClientImpl#serviceStop, this test will fail with error "Reloader is still alive".

          Show
          cheersyang Weiwei Yang added a comment - Attach v2 patch, added unit test. See TestTimelineClient#testTimelineClientCleanup , without the fix in TimelineClientImpl#serviceStop , this test will fail with error "Reloader is still alive".
          Hide
          tfriedr Thomas Friedrich added a comment -

          Hi Weiwei Yang, Hive still depends on an older version of Hadoop that doesn't have the JobClient with AutoCloseable interface. In addition I found that without MAPREDUCE-6618 calling close on the JobClient won't do anything either (and MAPREDUCE-6618 is only part of Hadoop 2.6.4 and 2.7.3). And when debugging, I found that Hive didn't call close on the JobClient to begin with.
          I will test a newer Hadoop with your patch and additional changes in Hive to confirm that your patch works for Hive. Then open another Hive JIRA linking to this one for the Hive changes.

          Show
          tfriedr Thomas Friedrich added a comment - Hi Weiwei Yang , Hive still depends on an older version of Hadoop that doesn't have the JobClient with AutoCloseable interface. In addition I found that without MAPREDUCE-6618 calling close on the JobClient won't do anything either (and MAPREDUCE-6618 is only part of Hadoop 2.6.4 and 2.7.3). And when debugging, I found that Hive didn't call close on the JobClient to begin with. I will test a newer Hadoop with your patch and additional changes in Hive to confirm that your patch works for Hive. Then open another Hive JIRA linking to this one for the Hive changes.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Thomas

          I think you need MAPREDUCE-6618 as well to fix this issue for hive, completely. Please let me know how it works. Thanks a lot.

          Show
          cheersyang Weiwei Yang added a comment - Hello Thomas I think you need MAPREDUCE-6618 as well to fix this issue for hive, completely. Please let me know how it works. Thanks a lot.
          Hide
          tfriedr Thomas Friedrich added a comment -

          Hi WeiWei,
          I finally got it to work in Hive and can confirm that your patch works. I also needed MAPREDUCE-6621 which is also only included in Hadoop 2.6.4 or later.
          In my tests with HiveServer2 I now see that all truststore reloader threads that are launched during job execution are cleaned up.
          Go ahead and submit this patch. Can it be committed into branch-2.6, branch-2.7, branch-2.8 and trunk?
          Thanks for the quick turn-around on the patch!

          Show
          tfriedr Thomas Friedrich added a comment - Hi WeiWei, I finally got it to work in Hive and can confirm that your patch works. I also needed MAPREDUCE-6621 which is also only included in Hadoop 2.6.4 or later. In my tests with HiveServer2 I now see that all truststore reloader threads that are launched during job execution are cleaned up. Go ahead and submit this patch. Can it be committed into branch-2.6, branch-2.7, branch-2.8 and trunk? Thanks for the quick turn-around on the patch!
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Thomas Friedrich

          Thanks for trying this out. Glad the patch worked, submitting it now. Hopefully we can have this patch reviewed and committed soon.

          Show
          cheersyang Weiwei Yang added a comment - Hello Thomas Friedrich Thanks for trying this out. Glad the patch worked, submitting it now. Hopefully we can have this patch reviewed and committed soon.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 49s trunk passed
          +1 compile 0m 26s trunk passed
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 57s trunk passed
          +1 javadoc 0m 26s trunk passed
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 25s the patch passed
          +1 javac 0m 25s the patch passed
          -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 3 new + 45 unchanged - 2 fixed = 48 total (was 47)
          +1 mvnsite 0m 28s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 28s the patch passed
          -1 unit 2m 15s hadoop-yarn-common in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          16m 40s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816424/YARN-5309.002.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ed4f4a72447f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9bdb5be
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12254/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12254/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 49s trunk passed +1 compile 0m 26s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 26s trunk passed +1 mvninstall 0m 25s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 3 new + 45 unchanged - 2 fixed = 48 total (was 47) +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 28s the patch passed -1 unit 2m 15s hadoop-yarn-common in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 16m 40s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816424/YARN-5309.002.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ed4f4a72447f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12254/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12254/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12254/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 4m 28s root in trunk failed.
          +1 compile 0m 26s trunk passed
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 54s trunk passed
          +1 javadoc 0m 26s trunk passed
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 32s the patch passed
          +1 javac 0m 32s the patch passed
          +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47)
          +1 mvnsite 0m 30s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          -1 whitespace 0m 0s The patch has 93 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 2s The patch 384 line(s) with tabs.
          +1 findbugs 1m 16s the patch passed
          +1 javadoc 0m 30s the patch passed
          -1 unit 2m 20s hadoop-yarn-common in the patch failed.
          -1 asflicense 0m 16s The patch generated 1 ASF License warnings.
          14m 59s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817018/YARN-5309.003.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6d7f0f058c28 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9bdb5be
          Default Java 1.8.0_91
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12261/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12261/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 4m 28s root in trunk failed. +1 compile 0m 26s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 26s trunk passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47) +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 93 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 2s The patch 384 line(s) with tabs. +1 findbugs 1m 16s the patch passed +1 javadoc 0m 30s the patch passed -1 unit 2m 20s hadoop-yarn-common in the patch failed. -1 asflicense 0m 16s The patch generated 1 ASF License warnings. 14m 59s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817018/YARN-5309.003.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d7f0f058c28 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12261/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12261/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12261/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 32s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 19s trunk passed
          +1 compile 0m 27s trunk passed
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 54s trunk passed
          +1 javadoc 0m 27s trunk passed
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 24s the patch passed
          +1 javac 0m 24s the patch passed
          +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47)
          +1 mvnsite 0m 27s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 1s the patch passed
          +1 javadoc 0m 24s the patch passed
          -1 unit 2m 8s hadoop-yarn-common in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          15m 49s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817046/YARN-5309.004.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4e77ebf1dbf4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9bdb5be
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12264/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12264/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 19s trunk passed +1 compile 0m 27s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47) +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 24s the patch passed -1 unit 2m 8s hadoop-yarn-common in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 15m 49s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClient Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817046/YARN-5309.004.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4e77ebf1dbf4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/12264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12264/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12264/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12264/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Patch is ready, can somebody help to review?
          The UT failure was not related. Thanks a lot.

          Show
          cheersyang Weiwei Yang added a comment - Patch is ready, can somebody help to review? The UT failure was not related. Thanks a lot.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the patch Weiwei Yang! Can you investigate the unit test failure? It looks like the failed unit test is the one you added as part of your patch. I suspect you have to update the pom to add org.bouncycastle.

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the patch Weiwei Yang ! Can you investigate the unit test failure? It looks like the failed unit test is the one you added as part of your patch. I suspect you have to update the pom to add org.bouncycastle.
          Hide
          cheersyang Weiwei Yang added a comment -

          My bad, my local UT passed both in positive and negative cases so I overlooked this result from Jenkins. I just added the dependency to pom and triggered a new jenkins run. Thanks a lot Varun Vasudev !

          Show
          cheersyang Weiwei Yang added a comment - My bad, my local UT passed both in positive and negative cases so I overlooked this result from Jenkins. I just added the dependency to pom and triggered a new jenkins run. Thanks a lot Varun Vasudev !
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 36s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 43s trunk passed
          +1 compile 0m 26s trunk passed
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 56s trunk passed
          +1 javadoc 0m 27s trunk passed
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 23s the patch passed
          +1 javac 0m 23s the patch passed
          +1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 41 unchanged - 2 fixed = 41 total (was 43)
          +1 mvnsite 0m 28s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 0m 59s the patch passed
          +1 javadoc 0m 25s the patch passed
          +1 unit 2m 16s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          16m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818180/YARN-5309.005.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 8e578b894a34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b5ee7db
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12339/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12339/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 43s trunk passed +1 compile 0m 26s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 26s the patch passed +1 compile 0m 23s the patch passed +1 javac 0m 23s the patch passed +1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 41 unchanged - 2 fixed = 41 total (was 43) +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 25s the patch passed +1 unit 2m 16s hadoop-yarn-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 16m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818180/YARN-5309.005.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 8e578b894a34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b5ee7db Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12339/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12339/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Varun Vasudev

          V5 patch resolved the UT failure, added org.bouncycastle in pom.xml just like what added in HADOOP-11230. Please let me know if it looks good to you. Thanks.

          Show
          cheersyang Weiwei Yang added a comment - Hello Varun Vasudev V5 patch resolved the UT failure, added org.bouncycastle in pom.xml just like what added in HADOOP-11230 . Please let me know if it looks good to you. Thanks.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Thomas Friedrich and Weiwei Yang, do you think this is a blocker for 2.7.3? If you think so, please set the target version to 2.7.3 so that we don't miss this issue in the release process. Thanks in advance.

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Thomas Friedrich and Weiwei Yang , do you think this is a blocker for 2.7.3? If you think so, please set the target version to 2.7.3 so that we don't miss this issue in the release process. Thanks in advance.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Akira Ajisaka

          I would prefer to have this fixed in 2.7.3, this currently crashed hive server2 in a secure environment. Thomas Friedrich what do you think?

          Show
          cheersyang Weiwei Yang added a comment - Hello Akira Ajisaka I would prefer to have this fixed in 2.7.3, this currently crashed hive server2 in a secure environment. Thomas Friedrich what do you think?
          Hide
          vvasudev Varun Vasudev added a comment -

          +1 for the latest patch. I'll commit this tomorrow if no one objects.

          Show
          vvasudev Varun Vasudev added a comment - +1 for the latest patch. I'll commit this tomorrow if no one objects.
          Hide
          vvasudev Varun Vasudev added a comment -

          Weiwei Yang - the patch doesn't apply cleanly on branch-2.7. Can you please add a patch for branch-2.7 if you need this to go into 2.7.3? Thanks!

          Show
          vvasudev Varun Vasudev added a comment - Weiwei Yang - the patch doesn't apply cleanly on branch-2.7. Can you please add a patch for branch-2.7 if you need this to go into 2.7.3? Thanks!
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Varun Vasudev

          Attached a patch for branch-2.7.3 and 2.8. Please check. Thanks for all the help.

          Show
          cheersyang Weiwei Yang added a comment - Hello Varun Vasudev Attached a patch for branch-2.7.3 and 2.8. Please check. Thanks for all the help.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 10m 2s branch-2.8 passed
          +1 compile 0m 23s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 0m 27s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 23s branch-2.8 passed
          +1 mvnsite 0m 35s branch-2.8 passed
          +1 mvneclipse 0m 18s branch-2.8 passed
          +1 findbugs 1m 14s branch-2.8 passed
          +1 javadoc 0m 27s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 0m 31s branch-2.8 passed with JDK v1.7.0_101
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_91
          +1 javac 0m 21s the patch passed
          +1 compile 0m 24s the patch passed with JDK v1.7.0_101
          +1 javac 0m 24s the patch passed
          +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23)
          +1 mvnsite 0m 29s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 21s the patch passed
          +1 javadoc 0m 24s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 28s the patch passed with JDK v1.7.0_101
          +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          37m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818795/YARN-5309.branch-2.8.001.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux cdbcdc5c7f80 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / cf79ac5
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12369/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12369/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 2s branch-2.8 passed +1 compile 0m 23s branch-2.8 passed with JDK v1.8.0_91 +1 compile 0m 27s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 23s branch-2.8 passed +1 mvnsite 0m 35s branch-2.8 passed +1 mvneclipse 0m 18s branch-2.8 passed +1 findbugs 1m 14s branch-2.8 passed +1 javadoc 0m 27s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 0m 31s branch-2.8 passed with JDK v1.7.0_101 +1 mvninstall 0m 26s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_91 +1 javac 0m 21s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_101 +1 javac 0m 24s the patch passed +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23) +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 21s the patch passed +1 javadoc 0m 24s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 28s the patch passed with JDK v1.7.0_101 +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 37m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818795/YARN-5309.branch-2.8.001.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux cdbcdc5c7f80 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / cf79ac5 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12369/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12369/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 35s branch-2.8 passed
          +1 compile 0m 28s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 21s branch-2.8 passed
          +1 mvnsite 0m 35s branch-2.8 passed
          +1 mvneclipse 0m 15s branch-2.8 passed
          +1 findbugs 1m 13s branch-2.8 passed
          +1 javadoc 0m 30s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 0m 34s branch-2.8 passed with JDK v1.7.0_101
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 24s the patch passed with JDK v1.8.0_91
          +1 javac 0m 24s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.7.0_101
          +1 javac 0m 26s the patch passed
          +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 29s the patch passed
          +1 javadoc 0m 28s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 33s the patch passed with JDK v1.7.0_101
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 34s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          36m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818795/YARN-5309.branch-2.8.001.patch
          JIRA Issue YARN-5309
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 2623ade54897 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / cf79ac5
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12370/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12370/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 35s branch-2.8 passed +1 compile 0m 28s branch-2.8 passed with JDK v1.8.0_91 +1 compile 0m 31s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 21s branch-2.8 passed +1 mvnsite 0m 35s branch-2.8 passed +1 mvneclipse 0m 15s branch-2.8 passed +1 findbugs 1m 13s branch-2.8 passed +1 javadoc 0m 30s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 0m 34s branch-2.8 passed with JDK v1.7.0_101 +1 mvninstall 0m 29s the patch passed +1 compile 0m 24s the patch passed with JDK v1.8.0_91 +1 javac 0m 24s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_101 +1 javac 0m 26s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 33s the patch passed with JDK v1.7.0_101 +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 34s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 36m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818795/YARN-5309.branch-2.8.001.patch JIRA Issue YARN-5309 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 2623ade54897 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / cf79ac5 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12370/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12370/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Committed to trunk, branch-2, branch-2.8, branch-2.7 and branch-2.7.3. Thanks Weiwei Yang!

          Show
          vvasudev Varun Vasudev added a comment - Committed to trunk, branch-2, branch-2.8, branch-2.7 and branch-2.7.3. Thanks Weiwei Yang !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10123/)
          YARN-5309. Fix SSLFactory truststore reloader thread leak in (vvasudev: rev 9ccf935b2cba5ac8a3e8124360d2203931397391)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10123/ ) YARN-5309 . Fix SSLFactory truststore reloader thread leak in (vvasudev: rev 9ccf935b2cba5ac8a3e8124360d2203931397391) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java
          Hide
          cheersyang Weiwei Yang added a comment -

          Varun Vasudev Thanks a lot for all your help!

          Show
          cheersyang Weiwei Yang added a comment - Varun Vasudev Thanks a lot for all your help!
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              tfriedr Thomas Friedrich
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development