Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6584

Remove trailing whitespaces from mapred-default.xml

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In MAPREDUCE-6583, test-patch reported that mapred-default.xml has many trailing whitespaces.

      1. MAPREDUCE-6584-branch-2.01.patch
        19 kB
        Akira Ajisaka
      2. MAPREDUCE-6584.02.patch
        20 kB
        Akira Ajisaka
      3. MAPREDUCE-6584.01.patch
        20 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          aw Allen Wittenauer added a comment -

          It's flagging it from the output generated from mvn site.

          Show
          aw Allen Wittenauer added a comment - It's flagging it from the output generated from mvn site.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I agree with you that mapred-default.xml should be fixed. However, the following warn message looks confusing.

          The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix.

          Actually the patch doesn't have trailing whitespaces.

          Show
          ajisakaa Akira Ajisaka added a comment - I agree with you that mapred-default.xml should be fixed. However, the following warn message looks confusing. The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix. Actually the patch doesn't have trailing whitespaces.
          Hide
          aw Allen Wittenauer added a comment - - edited

          This falls into the same category as the ASF license warnings after the unit test. Hadoop's build is buggy. In this case, not only are there whitespace issues but I suspect mapred-default.xml isn't getting removed from the site directories after a mvn clean [1]. Yetus has found that corner case where it is buggy. If Hadoop was building things correctly, then this becomes a non-issue.

          EDIT:

          [1] - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/gitdiffcontent.txt, that's exactly what's happening. mvn clean in mapreduce doesn't clean out the directories properly so the patch "inherits" any left over bits.

          Show
          aw Allen Wittenauer added a comment - - edited This falls into the same category as the ASF license warnings after the unit test. Hadoop's build is buggy. In this case, not only are there whitespace issues but I suspect mapred-default.xml isn't getting removed from the site directories after a mvn clean [1] . Yetus has found that corner case where it is buggy. If Hadoop was building things correctly, then this becomes a non-issue. EDIT: [1] - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/gitdiffcontent.txt , that's exactly what's happening. mvn clean in mapreduce doesn't clean out the directories properly so the patch "inherits" any left over bits.
          Hide
          mzuehlke Marco Zühlke added a comment -

          Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk.

          Show
          mzuehlke Marco Zühlke added a comment - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk .
          Hide
          mzuehlke Marco Zühlke added a comment -

          Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk.

          Show
          mzuehlke Marco Zühlke added a comment - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk.

          Agree. I executed the following commands and verified mapred-default.xml was removed by mvn clean.

          $ cd hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-core
          $ mvn site
          $ mvn clean
          (snip)
          [INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target
          [INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/resources (includes = [configuration.xsl, mapred-default.xml], excludes = [])
          (snip)
          

          We should call mvn clean between mvn site and whitespace check.

          Show
          ajisakaa Akira Ajisaka added a comment - it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk. Agree. I executed the following commands and verified mapred-default.xml was removed by mvn clean . $ cd hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-core $ mvn site $ mvn clean (snip) [INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target [INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/resources (includes = [configuration.xsl, mapred- default .xml], excludes = []) (snip) We should call mvn clean between mvn site and whitespace check.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Anyway, we should fix the trailing whitespaces in mapred-default.xml. Attaching a patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Anyway, we should fix the trailing whitespaces in mapred-default.xml. Attaching a patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 14s trunk passed
          +1 compile 0m 26s trunk passed with JDK v1.8.0_66
          +1 compile 0m 27s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 27s the patch passed with JDK v1.7.0_91
          +1 javac 0m 27s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91
          +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 25s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 24s Patch generated 1 ASF License warnings.
          19m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779502/MAPREDUCE-6584.01.patch
          JIRA Issue MAPREDUCE-6584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 7bb6f78b2761 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2c17b81
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 14s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_66 +1 compile 0m 27s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 15s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 30s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_91 +1 javac 0m 27s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91 +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 2m 25s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 1 ASF License warnings. 19m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779502/MAPREDUCE-6584.01.patch JIRA Issue MAPREDUCE-6584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 7bb6f78b2761 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c17b81 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6234/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Addressed the remaining whitespace issue.

          Show
          ajisakaa Akira Ajisaka added a comment - Addressed the remaining whitespace issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 58s trunk passed
          +1 compile 0m 25s trunk passed with JDK v1.8.0_66
          +1 compile 0m 26s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 27s the patch passed with JDK v1.7.0_91
          +1 javac 0m 27s the patch passed
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91
          +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 26s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          19m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779505/MAPREDUCE-6584.02.patch
          JIRA Issue MAPREDUCE-6584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux c6148e7abe04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2c17b81
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 58s trunk passed +1 compile 0m 25s trunk passed with JDK v1.8.0_66 +1 compile 0m 26s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 14s trunk passed +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 29s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_91 +1 javac 0m 27s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91 +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 2m 26s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 19m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779505/MAPREDUCE-6584.02.patch JIRA Issue MAPREDUCE-6584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux c6148e7abe04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c17b81 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6235/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          -1 asflicense

          This is because TestTaskLog creates logs under location directory. I'll create a separate jira.

          Show
          ajisakaa Akira Ajisaka added a comment - -1 asflicense This is because TestTaskLog creates logs under location directory. I'll create a separate jira.
          Hide
          ajisakaa Akira Ajisaka added a comment -
          Show
          ajisakaa Akira Ajisaka added a comment - Filed MAPREDUCE-6589 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch for branch-2.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch for branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 docker 0m 4s Docker failed to build yetus/hadoop:5d9212c.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch
          JIRA Issue MAPREDUCE-6584
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6236/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 docker 0m 4s Docker failed to build yetus/hadoop:5d9212c. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch JIRA Issue MAPREDUCE-6584 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6236/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          -1 docker

          Filed HADOOP-12681 for the issue in branch-2.

          Show
          ajisakaa Akira Ajisaka added a comment - -1 docker Filed HADOOP-12681 for the issue in branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 12m 40s branch-2 passed
          +1 compile 0m 24s branch-2 passed with JDK v1.8.0_66
          +1 compile 0m 25s branch-2 passed with JDK v1.7.0_91
          +1 mvnsite 0m 35s branch-2 passed
          +1 mvneclipse 0m 20s branch-2 passed
          +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_66
          +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_91
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.8.0_66
          +1 javac 0m 20s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_91
          +1 javac 0m 23s the patch passed
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 23s the patch passed with JDK v1.7.0_91
          +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 18s Patch generated 1 ASF License warnings.
          23m 19s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch
          JIRA Issue MAPREDUCE-6584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 2824fcd273d3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / babe025
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 72MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 40s branch-2 passed +1 compile 0m 24s branch-2 passed with JDK v1.8.0_66 +1 compile 0m 25s branch-2 passed with JDK v1.7.0_91 +1 mvnsite 0m 35s branch-2 passed +1 mvneclipse 0m 20s branch-2 passed +1 javadoc 0m 24s branch-2 passed with JDK v1.8.0_66 +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_91 +1 mvninstall 0m 26s the patch passed +1 compile 0m 20s the patch passed with JDK v1.8.0_66 +1 javac 0m 20s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_91 +1 javac 0m 23s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 20s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_91 +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 18s Patch generated 1 ASF License warnings. 23m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779516/MAPREDUCE-6584-branch-2.01.patch JIRA Issue MAPREDUCE-6584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 2824fcd273d3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / babe025 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 72MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6242/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1

          Show
          aw Allen Wittenauer added a comment - +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Allen Wittenauer for the review.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Allen Wittenauer for the review.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9031 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9031/)
          MAPREDUCE-6584. Remove trailing whitespaces from mapred-default.xml. (aajisaka: rev bee542817dd1cf525229aa903ca34d21b284f1ec)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9031 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9031/ ) MAPREDUCE-6584 . Remove trailing whitespaces from mapred-default.xml. (aajisaka: rev bee542817dd1cf525229aa903ca34d21b284f1ec) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development