In MAPREDUCE-6583, test-patch reported that mapred-default.xml has many trailing whitespaces.
distclean step is not working
It's flagging it from the output generated from mvn site.
I agree with you that mapred-default.xml should be fixed. However, the following warn message looks confusing.
The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix.
Actually the patch doesn't have trailing whitespaces.
This falls into the same category as the ASF license warnings after the unit test. Hadoop's build is buggy. In this case, not only are there whitespace issues but I suspect mapred-default.xml isn't getting removed from the site directories after a mvn clean . Yetus has found that corner case where it is buggy. If Hadoop was building things correctly, then this becomes a non-issue.
 - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/gitdiffcontent.txt, that's exactly what's happening. mvn clean in mapreduce doesn't clean out the directories properly so the patch "inherits" any left over bits.
Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk.
it locks like mvn clean is not called between Pre-patch trunk maven site verification and Applying patch to trunk.
Agree. I executed the following commands and verified mapred-default.xml was removed by mvn clean.
$ cd hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-core
$ mvn site
$ mvn clean
[INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target
[INFO] Deleting /Users/aajisaka/git/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/resources (includes = [configuration.xsl, mapred-default.xml], excludes = )
We should call mvn clean between mvn site and whitespace check.
Anyway, we should fix the trailing whitespaces in mapred-default.xml. Attaching a patch.
This message was automatically generated.
Addressed the remaining whitespace issue.
This is because TestTaskLog creates logs under location directory. I'll create a separate jira.
Attaching a patch for branch-2.
Filed HADOOP-12681 for the issue in branch-2.
Committed this to trunk, branch-2, and branch-2.8. Thanks Allen Wittenauer for the review.
FAILURE: Integrated in Hadoop-trunk-Commit #9031 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9031/)
MAPREDUCE-6584. Remove trailing whitespaces from mapred-default.xml. (aajisaka: rev bee542817dd1cf525229aa903ca34d21b284f1ec)