Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6583

Clarify confusing sentence in MapReduce tutorial document

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The current MapReduce tutorial has the following statement which is confusing:

      Overall, Mapper implementations are passed the Job for the job via the Job.setMapperClass(Class) method.

      The sentence seems to contradict itself. The code shows the mapper getting passed to the job. However, the working suggests that the job is passed to the mapper?

      https://hadoop.apache.org/docs/current/hadoop-mapreduce-client/hadoop-mapreduce-client-core/MapReduceTutorial.html#Mapper

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Marco Zühlke for filing and fixing it!

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Marco Zühlke for filing and fixing it!
          Hide
          mzuehlke Marco Zühlke added a comment -

          In the end is was a Yetus bug. See YETUS-260.

          Show
          mzuehlke Marco Zühlke added a comment - In the end is was a Yetus bug. See YETUS-260 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'll file a jira in Yetus project.

          Filed YETUS-257.

          Show
          ajisakaa Akira Ajisaka added a comment - I'll file a jira in Yetus project. Filed YETUS-257 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9005 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9005/)
          MAPREDUCE-6583. Clarify confusing sentence in MapReduce tutorial (aajisaka: rev 7995a6ea4dc524e5b17606359d09df72d771224a)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9005 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9005/ ) MAPREDUCE-6583 . Clarify confusing sentence in MapReduce tutorial (aajisaka: rev 7995a6ea4dc524e5b17606359d09df72d771224a) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md hadoop-mapreduce-project/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Kai Sasaki for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Kai Sasaki for the contribution.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 mvnsite 0m 33s trunk passed
          +1 mvnsite 0m 31s the patch passed
          -1 whitespace 0m 0s The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 asflicense 0m 18s Patch generated 1 ASF License warnings.
          1m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778660/HADOOP-12466.01.patch
          JIRA Issue MAPREDUCE-6583
          Optional Tests asflicense mvnsite
          uname Linux ec989ca2a3bf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0f82b5d
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/whitespace-eol.txt
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 29MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 33s trunk passed +1 mvnsite 0m 31s the patch passed -1 whitespace 0m 0s The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 asflicense 0m 18s Patch generated 1 ASF License warnings. 1m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778660/HADOOP-12466.01.patch JIRA Issue MAPREDUCE-6583 Optional Tests asflicense mvnsite uname Linux ec989ca2a3bf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0f82b5d whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/whitespace-eol.txt asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committing this patch.

          -1 whitespace

          Actually there are no trailing whitespace in the patch. I'll file a jira in Yetus project.

          -1 asflicense

          This is caused by HDFS-9173. I asked Zhe Zhang to fix it.

          Show
          ajisakaa Akira Ajisaka added a comment - Committing this patch. -1 whitespace Actually there are no trailing whitespace in the patch. I'll file a jira in Yetus project. -1 asflicense This is caused by HDFS-9173 . I asked Zhe Zhang to fix it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 mvnsite 0m 58s trunk passed
          +1 mvnsite 0m 32s the patch passed
          -1 whitespace 0m 0s The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
          2m 7s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778660/HADOOP-12466.01.patch
          JIRA Issue HADOOP-12466
          Optional Tests asflicense mvnsite
          uname Linux 2e11d9088a31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0f82b5d
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/artifact/patchprocess/whitespace-eol.txt
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Max memory used 30MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 58s trunk passed +1 mvnsite 0m 32s the patch passed -1 whitespace 0m 0s The patch has 81 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 2m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778660/HADOOP-12466.01.patch JIRA Issue HADOOP-12466 Optional Tests asflicense mvnsite uname Linux 2e11d9088a31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0f82b5d whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/artifact/patchprocess/whitespace-eol.txt asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8283/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 pending Jenkins.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins.
          Hide
          lewuathe Kai Sasaki added a comment -

          Akira Ajisaka I fixed the documentation and some typos. Could you review this?

          Show
          lewuathe Kai Sasaki added a comment - Akira Ajisaka I fixed the documentation and some typos. Could you review this?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm thinking mapper implementations are passed to the job. Therefore this sentence can be rewritten as follows:
          Overall, mapper implementations are passed to the job via Job.setMapperClass(Class) method.

          Show
          ajisakaa Akira Ajisaka added a comment - I'm thinking mapper implementations are passed to the job. Therefore this sentence can be rewritten as follows: Overall, mapper implementations are passed to the job via Job.setMapperClass(Class) method.

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              snowch chris snow
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development