[MAPREDUCE-6395] Improve the commit failure messages in MRAppMaster recovery

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: applicationmaster
• Labels: noob
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Brahma Reddy Battula
• Reporter: Gera Shegalov
• Created: 12/Jun/15 17:06
• Updated: 30/Aug/16 01:17
• Resolved: 19/Jun/15 09:36

Description

There are typos, and pluralis majestatis (royal we) or user-including "we" messages that are confusing to the users:

        if (commitSuccess) {
          shutDownMessage = "We crashed after successfully committing. Recovering.";
          forcedState = JobStateInternal.SUCCEEDED;
        } else if (commitFailure) {
          shutDownMessage = "We crashed after a commit failure.";
          forcedState = JobStateInternal.FAILED;
        } else {
          //The commit is still pending, commit error
          shutDownMessage = "We crashed durring a commit";
          forcedState = JobStateInternal.ERROR;
        }