Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6395

Improve the commit failure messages in MRAppMaster recovery

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are typos, and pluralis majestatis (royal we) or user-including "we" messages that are confusing to the users:

              if (commitSuccess) {
                shutDownMessage = "We crashed after successfully committing. Recovering.";
                forcedState = JobStateInternal.SUCCEEDED;
              } else if (commitFailure) {
                shutDownMessage = "We crashed after a commit failure.";
                forcedState = JobStateInternal.FAILED;
              } else {
                //The commit is still pending, commit error
                shutDownMessage = "We crashed durring a commit";
                forcedState = JobStateInternal.ERROR;
              }
      
      1. MAPREDUCE-6395-003.patch
        2 kB
        Brahma Reddy Battula
      2. MAPREDUCE-6395-002.patch
        2 kB
        Brahma Reddy Battula
      3. MAPREDUCE-6395.patch
        2 kB
        Brahma Reddy Battula

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8039/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8039/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2179/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2179/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/231/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/231/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/222/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/222/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2161 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2161/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2161 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2161/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #963 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/963/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #963 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/963/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/233/)
        MAPREDUCE-6395. Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/233/ ) MAPREDUCE-6395 . Improve the commit failure messages in MRAppMaster recovery. (Brahma Reddy Battula via gera) (gera: rev 10107243be66bae2212a2cd8575f9f5ade13fe9e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks a lot Gera Shegalov for reviewing and committing!!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks a lot Gera Shegalov for reviewing and committing!!!
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks Brahma Reddy Battula for the contribution! Committed to trunk and branch-2.

        Show
        jira.shegalov Gera Shegalov added a comment - Thanks Brahma Reddy Battula for the contribution! Committed to trunk and branch-2.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        +1, committing

        Show
        jira.shegalov Gera Shegalov added a comment - +1, committing
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 29s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 javadoc 9m 52s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 18s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        -1 findbugs 1m 11s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 15s Tests passed in hadoop-mapreduce-client-app.
            46m 31s  



        Reason Tests
        FindBugs module:hadoop-mapreduce-client-app



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740345/MAPREDUCE-6395-003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1c13519
        Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 29s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 18s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 1m 11s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 15s Tests passed in hadoop-mapreduce-client-app.     46m 31s   Reason Tests FindBugs module:hadoop-mapreduce-client-app Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740345/MAPREDUCE-6395-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1c13519 Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attached the patch to address the checkstyle issues..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attached the patch to address the checkstyle issues..
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Brahma Reddy Battula, thanks for the patch. Can you fix the remaining 80-column-width violations. The 150-line method length violation is fine for this patch.

        Show
        jira.shegalov Gera Shegalov added a comment - Brahma Reddy Battula , thanks for the patch. Can you fix the remaining 80-column-width violations. The 150-line method length violation is fine for this patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 6s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 38s The applied patch generated 4 new checkstyle issues (total was 75, now 77).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 13s Tests passed in hadoop-mapreduce-client-app.
            46m 57s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739874/MAPREDUCE-6395-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / b039e69
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 6s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 38s The applied patch generated 4 new checkstyle issues (total was 75, now 77). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 13s Tests passed in hadoop-mapreduce-client-app.     46m 57s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739874/MAPREDUCE-6395-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b039e69 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5805/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attaching patch to address checkstyle comments.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attaching patch to address checkstyle comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 9s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 9m 59s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 36s The applied patch generated 4 new checkstyle issues (total was 75, now 77).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 33s Tests passed in hadoop-mapreduce-client-app.
            47m 42s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739856/MAPREDUCE-6395.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / b039e69
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 9s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 36s The applied patch generated 4 new checkstyle issues (total was 75, now 77). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 33s Tests passed in hadoop-mapreduce-client-app.     47m 42s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739856/MAPREDUCE-6395.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b039e69 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5804/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Gera Shegalov Thanks a lot for your inputs.. Attached the patch based on your comments..Kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Gera Shegalov Thanks a lot for your inputs.. Attached the patch based on your comments..Kindly review..
        Hide
        jira.shegalov Gera Shegalov added a comment -

        I would like to suggest following messages:

        1. Job commit succeeded in a prior MRAppMaster attempt before it crashed. Recovering.
        2. Job commit failed in a prior MRAppMaster attempt before it crashed. Not retrying.
        3. Job commit from a prior MRAppMaster attempt is potentially in progress. Preventing multiple commit executions.
        4. Job finished cleanly, recording last MRAppMaster retry
        Show
        jira.shegalov Gera Shegalov added a comment - I would like to suggest following messages: Job commit succeeded in a prior MRAppMaster attempt before it crashed. Recovering. Job commit failed in a prior MRAppMaster attempt before it crashed. Not retrying. Job commit from a prior MRAppMaster attempt is potentially in progress. Preventing multiple commit executions. Job finished cleanly, recording last MRAppMaster retry
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Gera Shegalov thanks for reporting..

        Thinking fix like following, let me know your opinion..

        changes s/we/MRAppMaster/ durring/during

        if (commitSuccess) {
                  shutDownMessage = "MRAppMaster crashed after successfully committing. Recovering.";
                  forcedState = JobStateInternal.SUCCEEDED;
                } else if (commitFailure) {
                  shutDownMessage = "MRAppMaster crashed after a commit failure.";
                  forcedState = JobStateInternal.FAILED;
                } else {
                  //The commit is still pending, commit error
                  shutDownMessage = "MRAppMaster crashed during a commit";
                  forcedState = JobStateInternal.ERROR;
                }
        

        Apart from the mentioned following also going to change..Here I want to remove "we are"

         if (((JobImpl)job).getInternalState() != JobStateInternal.REBOOT) {
                  LOG.info("We are finishing cleanly so this is the last retry");
                  isLastAMRetry = true;
                }
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Gera Shegalov thanks for reporting.. Thinking fix like following, let me know your opinion.. changes s/we/MRAppMaster/ durring/during if (commitSuccess) { shutDownMessage = "MRAppMaster crashed after successfully committing. Recovering." ; forcedState = JobStateInternal.SUCCEEDED; } else if (commitFailure) { shutDownMessage = "MRAppMaster crashed after a commit failure." ; forcedState = JobStateInternal.FAILED; } else { //The commit is still pending, commit error shutDownMessage = "MRAppMaster crashed during a commit" ; forcedState = JobStateInternal.ERROR; } Apart from the mentioned following also going to change..Here I want to remove "we are" if (((JobImpl)job).getInternalState() != JobStateInternal.REBOOT) { LOG.info( "We are finishing cleanly so this is the last retry" ); isLastAMRetry = true ; }

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            jira.shegalov Gera Shegalov
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development